Skip to content

Commit 81a083c

Browse files
committed
improved code coverage
1 parent de94915 commit 81a083c

File tree

3 files changed

+37
-2
lines changed

3 files changed

+37
-2
lines changed

pom.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,9 @@
208208
</excludes>
209209

210210
<testFailureIgnore>false</testFailureIgnore>
211-
<disableXmlReport>true</disableXmlReport>
211+
<statelessTestsetReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
212+
<disable>true</disable>
213+
</statelessTestsetReporter>
212214
<useFile>false</useFile>
213215
</configuration>
214216
</plugin>

src/test/java/com/sergiofreire/xray/tutorials/springboot/UserRestControllerIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.sergiofreire.xray.tutorials.springboot;
22

3-
import org.json.JSONException;
43
import org.json.JSONObject;
54
import org.junit.jupiter.api.BeforeEach;
65
import org.junit.jupiter.api.Test;

src/test/java/com/sergiofreire/xray/tutorials/springboot/UserServiceUnitTest.java

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,28 @@ void setUp() {
4545

4646

4747
Mockito.when(userRepository.findById(john.getId())).thenReturn(Optional.of(john));
48+
Mockito.when(userRepository.findByUsername(john.getUsername())).thenReturn(john);
4849
Mockito.when(userRepository.findAll()).thenReturn(allUsers);
4950
Mockito.when(userRepository.findById(-99L)).thenReturn(Optional.empty());
5051
}
5152

53+
@Test
54+
void getUserByUsernameReturnsUserIfExisting() {
55+
Optional<User> user = userService.getUserByUsername("johndoe");
56+
57+
Mockito.verify(userRepository, VerificationModeFactory.times(1)).findByUsername(Mockito.anyString());
58+
assertThat(user.get().getName()).isEqualTo("John Doe");
59+
assertThat(user.get().getUsername()).isEqualTo("johndoe");
60+
}
61+
62+
@Test
63+
void getUserByUsernameReturnsEmptyIfNonExisting() {
64+
Optional<User> user = userService.getUserByUsername("unknown");
65+
66+
Mockito.verify(userRepository, VerificationModeFactory.times(1)).findByUsername(Mockito.anyString());
67+
assertThat(user).isNotPresent();
68+
}
69+
5270
@Test
5371
void getUserDetailsReturnsUserIfExisting() {
5472
Optional<User> user = userService.getUserDetails(999L);
@@ -66,6 +84,22 @@ void getUserDetailsReturnsEmptyIfNonExisting() {
6684
assertThat(user).isNotPresent();
6785
}
6886

87+
@Test
88+
void existsReturnsTrueIfExisting() {
89+
boolean exists = userService.exists("johndoe");
90+
91+
Mockito.verify(userRepository, VerificationModeFactory.times(1)).findByUsername(Mockito.anyString());
92+
assertThat(exists).isTrue();
93+
}
94+
95+
@Test
96+
void existsReturnsFalseIfNonExisting() {
97+
boolean exists = userService.exists("unknown");
98+
99+
Mockito.verify(userRepository, VerificationModeFactory.times(1)).findByUsername(Mockito.anyString());
100+
assertThat(exists).isFalse();
101+
}
102+
69103
@Test
70104
void getAllUsersReturnsAllExistingUsers() {
71105
User john = new User("John Doe", "johndoe", "dummypassword");

0 commit comments

Comments
 (0)