-
Notifications
You must be signed in to change notification settings - Fork 31
integrating turborepo #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We should add the "build-turbo" to a packages that have a "build" command. Once the comments are addressed I'm fine with merging this pr. |
…nto feat/turbo-build
| "email": "clemens@bitcoincomputer.io" | ||
| }, | ||
| "private": true, | ||
| "packageManager": "npm@10.2.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to specify the exact npm version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no we don't need the exact version, but turbo requires it. I added my latest version.
ClemensLey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
tested build flow from repos
TBC20
TBC721
Swap
Vite Template
NakamotoJS