Skip to content

Conversation

@jonty007
Copy link
Collaborator

tested build flow from repos
TBC20
TBC721
Swap
Vite Template
NakamotoJS

@ClemensLey
Copy link
Contributor

We should add the "build-turbo" to a packages that have a "build" command.

Once the comments are addressed I'm fine with merging this pr.

"email": "clemens@bitcoincomputer.io"
},
"private": true,
"packageManager": "npm@10.2.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify the exact npm version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no we don't need the exact version, but turbo requires it. I added my latest version.

Copy link
Contributor

@ClemensLey ClemensLey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ClemensLey ClemensLey merged commit 54ea89b into main Nov 21, 2024
@ClemensLey ClemensLey deleted the feat/turbo-build branch November 21, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants