Changes data representation to bigInt #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltardivo
changed the title
ClemensLey
reviewed
Mar 25, 2025
ClemensLey
reviewed
May 1, 2025
ClemensLey
reviewed
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Renames the
_amountinto_satoshisand changes the datatype fromnumbertobigint.Filters the duplicated BTC mainnet transactions from BIP34
Updates docs and types
Changes the target to ES2020
Breaking change
To migrate your app, change all occurrences of
_amountby_satoshis, and use the BigInt(n) constructor to create big integers. More information on how to handle BigInt can be found here.