Feat/claim tx without operator complete P2P #385
Conversation
ltardivo
left a comment
ltardivo
left a comment
There was a problem hiding this comment.
Looks good to me, we can add the description of the PR and maybe rename it, since here we are removing the chess-server
jonty007
changed the title
|
When the white player creates the game link, to be sent to the black player, we should update the text in the modal as follows: "Share this link with your opponent to start the game." -> "Share this link with the black player. The black player will get back to you with the final game link." |
|
The sign-in button doesn't work the second time |
|
update the message to ask user (add link to my-games page) to release fund from the /users page if the release-fund action failed |
| {data.winnerPubKey === data.userPubKey | ||
| ? `Congratiolations! You have won the game. ` | ||
| ? `Congratulations! You have won the game. ` | ||
| : `Sorry! You have lost the game. `} |
There was a problem hiding this comment.
- When a player lose the game, we should invite him/her to the
my-gamespage to release the funds. - Also, we need a way to go to the
my-gamespage, maybe from the left panel or from any place you think.
| requestRelease, | ||
| releaseFund, | ||
| ) | ||
| // !game ? ( |
There was a problem hiding this comment.
Is this commented code not needed anymore?
| ? `${chessContract.satoshis / BigInt(1e8)} ${computer.getChain()}` | ||
| : 'Loading...'} | ||
| </td> | ||
| <td>{game ? getGameState(game) : 'Loading...'}</td> |
There was a problem hiding this comment.
I got a typescript error here:
src/components/MyGames/index.tsx:157:32 - error TS2345: Argument of type 'Chess' is not assignable to parameter of type 'ChessContract'.
Type 'Chess' is missing the following properties from type 'ChessContract': satoshis, nameW, nameB, publicKeyW, and 10 more.
157 <td>{game ? getGameState(game) : 'Loading...'}</td>
~~~~
````
Chess App that's complete P2P
Typescript upgrade which fixes the long term related to Lib build
Removed chess server