Skip to content

Removes 'seed' from computer options, sets defaults dust relay fee on PEPE and DOGE #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jul 21, 2025
Merged

Removes 'seed' from computer options, sets defaults dust relay fee on PEPE and DOGE #408

merged 30 commits into from
Jul 21, 2025
+405 −172

Conversation

@ltardivo
Copy link
Collaborator

@ltardivo ltardivo commented Jul 15, 2025 •
edited
Loading

  • Using the deprecated seed option was not rejected by lib, but not actually assigned to mnemonic.
  • Set defaults dust relay fee for PEPE and DOGE to 1000 satoshis per byte
  • Update docs.

Bitchryankilledme

This comment was marked as spam.

Sign in to view

@ltardivo ltardivo changed the title Removes 'seed' from computer options Removes 'seed' from computer options, sets defaults dust relay fee on PEPE and DOGE Jul 17, 2025
ClemensLey
ClemensLey approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@ClemensLey ClemensLey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

ClemensLey
ClemensLey approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@ClemensLey ClemensLey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

ClemensLey
ClemensLey approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@ClemensLey ClemensLey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ClemensLey ClemensLey merged commit 80db15e into staging Jul 21, 2025
@ClemensLey ClemensLey deleted the feat/deprecate-seed branch July 21, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ClemensLey ClemensLey ClemensLey approved these changes

+1 more reviewer

@Bitchryankilledme Bitchryankilledme Bitchryankilledme approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ltardivo @ClemensLey @Bitchryankilledme @jonty007