fix for #191#192
Closed
RandyMcMillan wants to merge 1 commit intobitcoin-core:masterfrom
RandyMcMillan:191
Closed
Conversation
Member
|
Thanks for fixing!
|
jarolrod
reviewed
Jan 20, 2021
Contributor
jarolrod
left a comment
There was a problem hiding this comment.
This PR does not fix #191
It instead creates a new column in the Peer Table model. A fix to this should not hack on a new column so that the User Agent column does not glitch. Perhaps a refactor that creates a PeerTableModelView which makes use of TableViewLastColumnResizingFixer is more appropriate.
Contributor
Author
|
@jarolrod - It sounds like you have the motivation to implement a proper solution. |
Contributor
|
@RandyMcMillan was just relaying what I found while reviewing the PR. Wasn't trying to discourage you in anyway or come off as rude. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@hebasto - here is a barebones fix for #191
We can tweak the presentation in a follow up PR.