src/net.cpp: Fail to listen alert text break fix#476
Closed
RandyMcMillan wants to merge 1 commit intobitcoin-core:masterfrom
Closed
src/net.cpp: Fail to listen alert text break fix#476RandyMcMillan wants to merge 1 commit intobitcoin-core:masterfrom
RandyMcMillan wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
Contributor
Author
|
When another instance of bitcoin is running:
Before: After: |
shaavan
approved these changes
Nov 20, 2021
Contributor
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
ACK a5097f3
Simple but necessary change. Before line break, the usage of -listen=0 was not evident, and - could have confused a simple text hyphen. This PR removes the scope for that doubt.
Nice catch, @RandyMcMillan!
|
Concept ACK. |
Member
|
Why don't use Line 497 in 19815b0 which we already use in our code? For translated messages we cannot be sure that the chosen location of the hardcoded |
Member
|
Could you move this PR into the main repo because it changes the code outside the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.