Skip to content

gui: Separate rpcconsole from nodewindow#98

Closed
RandyMcMillan wants to merge 1 commit intobitcoin-core:masterfrom
RandyMcMillan:nodewindow-gui
Closed

gui: Separate rpcconsole from nodewindow#98
RandyMcMillan wants to merge 1 commit intobitcoin-core:masterfrom
RandyMcMillan:nodewindow-gui

Conversation

@RandyMcMillan
Copy link
Copy Markdown
Contributor

@RandyMcMillan RandyMcMillan commented Sep 18, 2020

Separate RCPConsole from Node Window

Copy link
Copy Markdown
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept -0. File rename was avoided when the title was changed, see bitcoin/bitcoin#17096.

<y>0</y>
<width>740</width>
<height>430</height>
<width>777</width>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change.

@Sjors
Copy link
Copy Markdown
Member

Sjors commented Sep 21, 2020

This change is more suitable for a larger PR that changes something meaningful in node window, see developer notes:

Do not submit patches solely to modify the style of existing code.

@RandyMcMillan
Copy link
Copy Markdown
Contributor Author

@Sjors - the idea was to move toward restructuring the rpcConsole implementation to a "data_model view controller" type implementation - as it is now the "Node Window" seems too monolithic - the information, console, network traffic and peers tabs should be separated to follow a better design paradigm. I believe this is an impediment to better GUI design.

@hebasto
Copy link
Copy Markdown
Member

hebasto commented Sep 22, 2020

@RandyMcMillan

@Sjors - the idea was to move toward restructuring the rpcConsole implementation to a "data_model view controller" type implementation - as it is now the "Node Window" seems too monolithic - the information, console, network traffic and peers tabs should be separated to follow a better design paradigm. I believe this is an impediment to better GUI design.

Nice topic for the Bitcoin Design Community!

@promag
Copy link
Copy Markdown
Contributor

promag commented Sep 22, 2020

@RandyMcMillan is the file rename a blocker?

@Sjors
Copy link
Copy Markdown
Member

Sjors commented Sep 22, 2020

This commit can be part of a PR that actually does the restructuring.

@RandyMcMillan RandyMcMillan changed the title rename debugwindow.ui to nodewindow.ui gui: Seperate rpcconsole from nodewindow Sep 26, 2020
@RandyMcMillan RandyMcMillan changed the title gui: Seperate rpcconsole from nodewindow gui: Separate rpcconsole from nodewindow Sep 26, 2020
@RandyMcMillan
Copy link
Copy Markdown
Contributor Author

RandyMcMillan commented Sep 26, 2020

Implementing the change...thanks for the feed back.
I wasn't sure whether to do this change incrementally.
More to follow. I will reopen as a draft when it is a little further along.

@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants