Fix $Proxy.wrap mapping for empty structs with no fields#104
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Jul 23, 2024
Merged
Fix $Proxy.wrap mapping for empty structs with no fields#104ryanofsky merged 1 commit intobitcoin-core:masterfrom
ryanofsky merged 1 commit intobitcoin-core:masterfrom
Conversation
Trying to pass an empty $Proxy.wrap struct with no fields fails because BuildOne overload for the last field number is incorrectly declared to accept an lvalue Builder reference instead of a univeral reference, and the CustomBuildField overload which calls BuildOne passes an rvalue Builder. The problem did not happen as long as the wrapped struct had at least one field because CustomBuildField would call the other BuildOne overload for the first field number which accepts an rvalue Builder, and that BuildOne overload would call the next BuildOne overload for the next field number, passing the builder as an lvalue. A test is included which triggers the bug. Compiler output before the bugfix looked like: include/mp/proxy-types.h:1066:5: error: no matching function for call to 'BuildOne' 1066 | BuildOne<0>(local_type, invoke_context, output.init(), value); include/mp/proxy-types.h:1050:6: note: candidate function [with index = 0, LocalType = mp::test::FooEmpty, Value = mp::test::FooEmpty, Output = mp::test::messages::FooEmpty::Builder] not viable: expects an lvalue for 3rd argument 1050 | void BuildOne(TypeList<LocalType> param,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to pass an empty struct that is annotated with
$Proxy.wrapand has no data fields fails because theBuildOneoverload for the last field number is incorrectly declared to accept an lvalue builder reference instead of a universal reference, and theCustomBuildFieldoverload which callsBuildOnepasses anrvaluebuilder, so the call fails with error:The problem did not happen as long as the wrapped struct had at least one field because
CustomBuildFieldwould call a differentBuildOneoverload for the first field number which does accept rvalue builders, and thatBuildOneoverload would call the nextBuildOneoverload for the next field number passing the builder as an lvalue.