Fix clang compiler warnings#62
Merged
ryanofsky merged 3 commits intobitcoin-core:masterfrom Dec 22, 2021
Merged
Conversation
Warnings look like "warning: 'initError' overrides a member function but is not marked 'override' [-Wsuggest-override]" Warnings were originally reported by Sjors Provoost <sjors@sprovoost.nl> and are tracked in bitcoin-core#61 The same warnings were previously disabled for GCC in 05f9817 bitcoin-core#40 and that change is extended here to apply to clang. The methods triggering the warnings are not virtual in all cases and should not have the override keyword.
Warnings look like "warning: destructor called on non-final 'mp::ProxyClient<ipc::capnp::messages::ActorCallback>' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]" Warnings were originally reported by Sjors Provoost <sjors@sprovoost.nl> and are tracked in bitcoin-core#61 Avoid these by adding final keywords to generated class declarations
…backImpl Warnings look like "warning: destructor called on non-final 'mp::ProxyCallbackImpl<void>' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]" Avoid these by adding final keyword to class declaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid and suppress various warnings reported in #61