Add ReadDestTemp function to make it easier to call ReadField with less boilerplate#81
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Oct 4, 2022
Merged
Conversation
…ss boilerplate Add RestDestTemp function to simplify ReadField callers that just want to read a field into a new object. Instead of requiring ReadField callers to construct the object in advance and pass with ReadDestValue, or to write custom emplace function with ReadDestEmplace, they call RestDestTemp to make ReadField just return a temporary object that can be moved from. Add some test coverage for this. Also add missing documentation for ReadDestEmplace and ReadDestValue classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
RestDestTempfunction to simplifyReadFieldcalls that just want to read a field into a new object.Instead of requiring
ReadFieldcallers to construct the object in advance and pass it withReadDestValue, or to write a custom emplace function and pass it withReadDestEmplace, they can useRestDestTempto makeReadFieldjust construct a temporary object internally that can be moved from.Add test coverage for this. Also add missing documentation comments for
ReadDestEmplaceandReadDestValueclasses.