build: Fix missing Cap'n Proto include directories#82
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Oct 4, 2022
Merged
build: Fix missing Cap'n Proto include directories#82ryanofsky merged 1 commit intobitcoin-core:masterfrom
ryanofsky merged 1 commit intobitcoin-core:masterfrom
Conversation
Two bugs configuring Cap'n Proto include directories were reported by Sjors Provoost <sjors@sprovoost.nl> in bitcoin-core#75 They appear to have gone undetected because they were masked in other contexts by CMAKE_INCLUDE_PATH and NIX_CFLAGS_COMPILE environment variable settings (bitcoin-core#75 (comment)) The first bug is missing ${CAPNP_INCLUDE_DIRECTORY} target_include_directories in the util target. This resulted in a compile error "include/mp/util.h:8:10: fatal error: 'capnp/schema.h' file not found" The second bug was misspelling CAPNP_INCLUDE_DIRS as capnp_INCLUDE_DIRS in the configure check for kj/filesystem.h, which caused HAVE_KJ_FILESYSTEM to be unset and could result in runtime errors like: capnp compile: --import-path=/prefix/include: no such directory Try 'capnp compile --help' for more information. terminate called after throwing an instance of 'std::runtime_error' what(): Invoking capnp failed
Member
|
tACK c753623 |
Collaborator
Author
|
Thanks for reporting this and testing the patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs configuring Cap'n Proto include directories were reported by sjors in #75
They appear to have gone undetected because they were masked in other contexts by
CMAKE_INCLUDE_PATHandNIX_CFLAGS_COMPILEenvironment variable settings (#75 (comment))The first bug is missing
${CAPNP_INCLUDE_DIRECTORY}target_include_directories in theutiltarget. This resulted in a compile errorinclude/mp/util.h:8:10: fatal error: 'capnp/schema.h' file not foundThe second bug was misspelling
CAPNP_INCLUDE_DIRSascapnp_INCLUDE_DIRSin the configure check forkj/filesystem.h, which causedHAVE_KJ_FILESYSTEMto be unset and could result in runtime errors like: