-
Couldn't load subscription status.
- Fork 37
Design Documentation Update #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. LLM Linter (✨ experimental)Possible typos and grammar issues:
drahtbot_id_5_m |
7756fdc to
459a730
Compare
|
@theuni you may be interested in this, it describes things like how callbacks can be implemented |
|
This is a helpful update. As someone getting familiar with this, the new details really helped clarify the design. |
|
Concept ACK on expanding documentation, and thanks for adding these graphics. Reviewer hint, switch to the rich diff:
@ryanofsky is probably best qualified to check correctness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review ACK 459a730. These updates are very good, and I think information about callbacks and context parameters should be especially helpful. I left a number of suggestions below, which can be addressed here or in a followup. You can let me know which you prefer.
|
Thanks for the review @ryanofsky . I made the suggested changes. |

This PR contains an attempt to improve the design documentation to help new contributors to the repo. It adds more details about
BuildField,ReadFieldandPassField. It explains how Callbacks, ThreadMaps and Async processing work.