Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Nov 18, 2025

Whenever I work on changes that require comparison, such as benchmarking, I end up with two or more build directories that provide different binary variants simultaneously. Adding these build directories to .gitignore makes the workflow a bit easier.

Additionally, a trivial refactoring is included to reduce the code.

# Default CMake build directory.
/build
# CMake build directories.
/*build*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same pattern is used in Bitcoin Core.

@real-or-random
Copy link
Contributor

Concept ACK

We could also get rid of build-aux entirely by moving the contents of the only file into configure.ac. I think that would be nice. build-aux can be confusing to people familiar only with CMake, and it hinders tab-completion with CMake dirs etc... What do you think?

@hebasto
Copy link
Member Author

hebasto commented Nov 18, 2025

We could also get rid of build-aux entirely by moving the contents of the only file into configure.ac. I think that would be nice.

I think the main purpose of:

AC_CONFIG_AUX_DIR([build-aux])
is to keep the top level of the repo uncluttered. Without it, it would end up filled as follows:

$ ./autogen.sh | grep -v libtoolize
configure.ac:38: installing './ar-lib'
configure.ac:36: installing './compile'
configure.ac:23: installing './config.guess'
configure.ac:23: installing './config.sub'
configure.ac:26: installing './install-sh'
configure.ac:26: installing './missing'
Makefile.am: installing './depcomp'
parallel-tests: installing './test-driver'

build-aux can be confusing to people familiar only with CMake, and it hinders tab-completion with CMake dirs etc... What do you think?

The build-aux directory could be renamed. Perhaps to something like autotools-aux?

@real-or-random
Copy link
Contributor

Oh sure! Even I forgot the main purpose of the directory.

The build-aux directory could be renamed. Perhaps to something like autotools-aux?

I like that suggestion.

This change improves separation from CMake build directories, which
typically use the "build" prefix.

Additionally, corresponding `.gitignore` entries have been refactored.
@hebasto hebasto force-pushed the 251118-ignore-build branch from 90b3339 to 748c0fd Compare November 20, 2025 12:43
@hebasto
Copy link
Member Author

hebasto commented Nov 20, 2025

The build-aux directory could be renamed. Perhaps to something like autotools-aux?

I like that suggestion.

Thanks! Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants