-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add CMake build directory patterns to .gitignore
#1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| # Default CMake build directory. | ||
| /build | ||
| # CMake build directories. | ||
| /*build* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same pattern is used in Bitcoin Core.
|
Concept ACK We could also get rid of |
I think the main purpose of: Line 22 in b6c2a3c
The |
|
Oh sure! Even I forgot the main purpose of the directory.
I like that suggestion. |
This change improves separation from CMake build directories, which typically use the "build" prefix. Additionally, corresponding `.gitignore` entries have been refactored.
90b3339 to
748c0fd
Compare
Thanks! Done. |
Whenever I work on changes that require comparison, such as benchmarking, I end up with two or more build directories that provide different binary variants simultaneously. Adding these build directories to
.gitignoremakes the workflow a bit easier.Additionally, a trivial refactoring is included to reduce the code.