Skip to content

Make constants static: #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2019
Merged

Make constants static: #552

merged 1 commit into from
Feb 21, 2019

Conversation

@roconnor-blockstream
Copy link
Contributor

@roconnor-blockstream roconnor-blockstream commented Aug 15, 2018

static const secp256k1_ge secp256k1_ge_const_g;
static const int CURVE_B;

@roconnor-blockstream
Make constants static:
496c5b4 
static const secp256k1_ge secp256k1_ge_const_g;
static const int CURVE_B;
@DesWurstes
Copy link
Contributor

DesWurstes commented Aug 30, 2018 •
edited
Loading

I've verified that after this Pull Request gets merged, no symbols that shouldn't be exported can be accessed from outside.

$ nm -g ./libsecp256k1_la-secp256k1.o 
000000000001f480 S _CURVE_B
                 U ___gmpn_gcdext
                 U ___gmpn_get_str
                 U ___gmpn_set_str
                 U ___gmpn_sub_n
                 U ___memset_chk
                 U ___stderrp
                 U _abort
                 U _fprintf
                 U _free
                 U _malloc
                 U _memcpy
                 U _memset
000000000000b550 T _secp256k1_context_clone
000000000000aea0 T _secp256k1_context_create
000000000000b710 T _secp256k1_context_destroy
000000000000ec40 T _secp256k1_context_randomize
000000000000b760 T _secp256k1_context_set_error_callback
000000000000b740 T _secp256k1_context_set_illegal_callback
000000000000dd40 T _secp256k1_ec_privkey_negate
000000000000e0d0 T _secp256k1_ec_privkey_tweak_add
000000000000e740 T _secp256k1_ec_privkey_tweak_mul
000000000000ec90 T _secp256k1_ec_pubkey_combine
000000000000d850 T _secp256k1_ec_pubkey_create
000000000000de60 T _secp256k1_ec_pubkey_negate
000000000000b810 T _secp256k1_ec_pubkey_parse
000000000000c530 T _secp256k1_ec_pubkey_serialize
000000000000e380 T _secp256k1_ec_pubkey_tweak_add
000000000000e890 T _secp256k1_ec_pubkey_tweak_mul
000000000000d7e0 T _secp256k1_ec_seckey_verify
000000000000d150 T _secp256k1_ecdsa_sign
000000000000cd90 T _secp256k1_ecdsa_signature_normalize
000000000000c830 T _secp256k1_ecdsa_signature_parse_compact
000000000000c6f0 T _secp256k1_ecdsa_signature_parse_der
000000000000ccd0 T _secp256k1_ecdsa_signature_serialize_compact
000000000000c950 T _secp256k1_ecdsa_signature_serialize_der
000000000000cf70 T _secp256k1_ecdsa_verify
000000000001f4f8 S _secp256k1_nonce_function_default
000000000001f500 S _secp256k1_nonce_function_rfc6979
000000000000b780 T _secp256k1_scratch_space_create
000000000000b7f0 T _secp256k1_scratch_space_destroy

@gmaxwell
Copy link
Contributor

gmaxwell commented Sep 4, 2018

ACK

@gmaxwell gmaxwell merged commit 496c5b4 into bitcoin-core:master Feb 21, 2019
gmaxwell added a commit that referenced this pull request Feb 21, 2019
@gmaxwell
Merge #552: Make constants static:
2ebdad7 
496c5b4 Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B; (Russell O'Connor)

Pull request description:

  static const secp256k1_ge secp256k1_ge_const_g;
  static const int CURVE_B;

Tree-SHA512: df8d34777d3b1b90eef875d50c2870e2480f08685b399a22eaf584ce294766e0de3a41523757a23e311e633886c89400313421282beca791326a06695f348940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roconnor-blockstream @DesWurstes @gmaxwell