add: addrman-observer support #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I just saw #325, which changes the way the fork-observer config is written. Should this be used here too? |
0xB10C
force-pushed
the
2024-04-add-addrman-observer
branch
from
52801fc to
46b3d86
Compare
Contributor
Author
|
Using |
pinheadmz
reviewed
Jun 4, 2024
| self.write_addrman_observer_config() | ||
| if "grafana" in self.services: | ||
| self.write_grafna_config() | ||
| self.write_grafana_config() |
Contributor
|
Had to zoom waaaaay in but there they are!
|
Contributor
|
Ok this is great thanks |
Contributor
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an addrman-observer service and tests. While the addrman-observer front-end is still WIP, it should be usable for warnet.
On the frontend, you should be able to add
?url=<tank_id>to load the addrman of that tank. The same thing should also work with thefetch from URLand tank names.