Add Replacement Cycling scenario #354
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplsgrant
force-pushed
the
2024-05-rep-cycle
branch
2 times, most recently
from
30bbf78 to
eb46054
Compare
Collaborator
|
Concept ACK - assuming you'll move this out of draft when it's "ready for review?" |
mplsgrant
force-pushed
the
2024-05-rep-cycle
branch
from
23f1912 to
4ef957d
Compare
Contributor
|
This requests issue is very annoying 😢 |
mplsgrant
force-pushed
the
2024-05-rep-cycle
branch
from
080b006 to
18391fd
Compare
Contributor
You can try rebasing on main now |
mplsgrant
force-pushed
the
2024-05-rep-cycle
branch
3 times, most recently
from
e6226cf to
4bf5137
Compare
Add ariard's replacement cycling test nearly verbatim:update its base class to warnet, and add a call to `generatetoaddress` because test framework assumes a kick-started chain by default.
This ensures sufficient funds for fees. The ln_init.py process will fail due to insufficient funds if the number of coins it generates is evenly divisible relative to the number of recipients.
mplsgrant
force-pushed
the
2024-05-rep-cycle
branch
from
4bf5137 to
c3820c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I can not run ariard's replacement cycling test in Warnet.
Cause
A number of the test framework components available in Bitcoin Core have not been ported into Warnet.
Solution
Limitations
There is a conflict with the ln cli test.Wins
The test runs without meaningful augmentation. This is great because it points us in a direction of copy/pasting tests that run today in Core's functional test framework. We can then augment the tests to work in realistic environments with lightning nodes and other future tank types.
✨ New Wins
connect_nodesworking.Future work