image: build by commit hash, not branch #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinheadmz
approved these changes
Jul 8, 2024
Contributor
pinheadmz
left a comment
pinheadmz
left a comment
There was a problem hiding this comment.
ACK
reviewed and tested. image is building locally right now but it checked out the right HEAD so I think we're good here
Comment on lines
+36
to
+39
| && git clone --depth 1 "https://github.com/${REPO}" \ | ||
| && cd bitcoin \ | ||
| && git fetch --depth 1 origin "$COMMIT_SHA" \ | ||
| && git checkout "$COMMIT_SHA" \ |
Contributor
There was a problem hiding this comment.
TIL you can do this: fetch a commit from another branch even though you cloned depth 1
Contributor
Author
There was a problem hiding this comment.
fetch is from the remote, so really the clone is just needed to setup git with the remote, then you can fetch any commit_sha (at depth 1) after that.
It's prob even possible to do in a one-liner, but I don't got time for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build an image from any
repo + <commit_hash>.I think this is more flexible and more useful.
It's also a step towards #389 and #181