use scenario filenames in list scenarios when using a remote scenario

[willcl-ark]

Fixes #393

[mplsgrant]

nit: I believe we can remove scenario_path = None

[willcl-ark]

done in d50ba92

[mplsgrant]

I like this overall and it works well with #384: https://github.com/mplsgrant/warnet/actions/runs/9844946239/job/27179455585#step:8:361

However, I'll need to rerun with the logging changes to be sure.

[willcl-ark]

I like this overall and it works well with #384: mplsgrant/warnet/actions/runs/9844946239/job/27179455585#step:8:361

However, I'll need to rerun with the logging changes to be sure.

Great thanks! I was just trying to address your comment when I spotted that we duplicated most of the code in our two scenario run functions, so refactored that in the push I just made:

https://github.com/bitcoin-dev-project/warnet/compare/0c66be68ec2f75393ba33712df03c3eac9771f0f..55e4411062f5daaf991e482da0b2830a0bb25099

[pinheadmz]

concept ACK, maybe a nice improvement or two suggested

[pinheadmz]

I think it makes more sense to do this in cli/scenarios.py and just pass the name to the server. Could even theoretically be an option to add a custom --name when running a scenario. for example if you want to run the same scenario a few times in parallel.

warcli scenarios stop could even accept that name as an option instead of a pid !

[willcl-ark]

done in d50ba92

[pinheadmz]

post-merge ACK, nice looks good

(.venv) --> warcli scenarios run miner_std
Running scenario miner_std with PID 9231 in the background...
(.venv) --> warcli scenarios active
┏━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━┓
┃ Active ┃ Cmd        ┃ Network ┃ Pid  ┃
┡━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━┩
│ True   │ miner_std  │ warnet  │ 9231 │
└────────┴────────────┴─────────┴──────┘
(.venv) --> warcli scenarios run --name miner2 miner_std --allnodes
-32000: Scenario --name not found at /root/warnet/src/scenarios/--name.py.
(.venv) --> warcli scenarios run-file src/scenarios/tx_flood.py 
Running scenario tx_flood with PID 9337 in the background...
(.venv) --> warcli scenarios active
┏━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━┓
┃ Active ┃ Cmd        ┃ Network ┃ Pid  ┃
┡━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━┩
│ True   │ miner_std  │ warnet  │ 9231 │
│ True   │ tx_flood   │ warnet  │ 9337 │
└────────┴────────────┴─────────┴──────┘
(.venv) --> warcli scenarios run miner_std --allnodes --interval=1 --mature
Running scenario miner_std with PID 9400 in the background...
(.venv) --> warcli scenarios active
┏━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━┓
┃ Active ┃ Cmd                                        ┃ Network ┃ Pid  ┃
┡━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━┩
│ True   │ miner_std                                  │ warnet  │ 9231 │
│ True   │ tx_flood                                   │ warnet  │ 9337 │
│ True   │ miner_std --allnodes --interval=1 --mature │ warnet  │ 9400 │
└────────┴────────────────────────────────────────────┴─────────┴──────┘