Skip to content

refactor(deps): simplify installation of NetBSD build deps #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2024
Merged

refactor(deps): simplify installation of NetBSD build deps #1601

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b67475
refactor(deps): make NetBSD build deps install more consistent
bitcoin-tools Oct 5, 2024
6817637
suppress stdout in NetBDS configure
bitcoin-tools Oct 5, 2024
0174c55
Merge branch 'master' into 1600-feat-refactor-netbsd-build-dep-instal…
bitcoin-tools Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions nodebuilder
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,12 +859,7 @@ install_build_dependencies_netbsd()
dependencies=$(torsocks curl --fail --silent --show-error --location --retry 2 "${BUILD_DEPENDENCIES_URL}") ||
dependencies=$(curl --fail --silent --show-error --location --retry 5 "${BUILD_DEPENDENCIES_URL}")
[ -z "${dependencies:-}" ] && throw_error "The list of dependencies is empty."
for package in ${dependencies}; do
if ! sudo pkgin -y install "${package}"; then
cat /var/db/pkgin/pkg_install-err.log
throw_error "Failed to install ${package}"
fi
done
printf '%s\n' "${dependencies}" | xargs sudo pkgin -y install > /dev/null
# TODO: Remove gcc-12 installation on next line when NetBSD updates the default version of gcc to support C++ 20 features. Bitcoin Core requires gcc with support for C++ 20 features.
sudo pkgin -y install gcc12 && export PATH="/usr/pkg/gcc12/bin:${PATH}"
}
Expand Down