Skip to content

refactor(scalability): use variable for compile directory #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2024
Merged

refactor(scalability): use variable for compile directory #459

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87f857a
refactor(compile): use variable for working directory
bitcoin-tools Mar 16, 2024
13228a3
feat: protect against unset directory
bitcoin-tools Mar 16, 2024
ebcddee
fix(ui) suppress ICU message
bitcoin-tools Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions nodebuilder
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,13 +409,14 @@ esac
if [ "${current_bitcoin_version}" = "${target_bitcoin_version_padded}" ]; then
printf '%s\n' "found."
elif [ "$(uname -s)" = 'Linux' ] && [ "$(get_os_release_type)" = "alpine" ]; then
compile_directory="${temp_directory}/compile_bitcoin"
stderr_compile_log_file="${temp_directory}/stderr_install.log"
printf '%s\n %s' "not found." "Installing build dependencies... "
apk --quiet add alpine-sdk libffi-dev autoconf automake db-dev boost boost-dev libtool libevent-dev 2> "${stderr_compile_log_file}"
grep -v "ICU with non-English" -A2 -B1 "${stderr_compile_log_file}" >&2 || true
apk --quiet add alpine-sdk libffi-dev autoconf automake db-dev boost boost-dev libtool libevent-dev |
grep -v "ICU with non-English locales" -A2 -B1 || true
printf '%s\n %s' "ok." "Downloading Bitcoin source code... "
git clone --branch "v${target_bitcoin_version}" --single-branch --depth 1 --quiet -c advice.detachedHead=false https://github.com/bitcoin/bitcoin.git "${temp_directory}"/compile_bitcoin
cd "${temp_directory}"/compile_bitcoin/
git clone --branch "v${target_bitcoin_version}" --single-branch --depth 1 --quiet -c advice.detachedHead=false https://github.com/bitcoin/bitcoin.git "${compile_directory}"
cd "${compile_directory}"/
printf '%s\n %s' "ok." "Analyzing hardware confgiruation... "
./autogen.sh > /dev/null 2> "${stderr_compile_log_file}"
grep -v "build-aux" "${stderr_compile_log_file}" >&2 || true
Expand All @@ -433,8 +434,9 @@ elif [ "$(uname -s)" = 'Linux' ] && [ "$(get_os_release_type)" = "alpine" ]; the
grep -v "Ran 3 tests in " -A1 -B2 "${stderr_compile_log_file}" >&2 || true
printf '%s\n %s' "ok." "Installing Bitcoin... "
make install > /dev/null
cd "${temp_directory}"/
rm "${stderr_compile_log_file}"
rm -rf "${temp_directory}"/compile_bitcoin/
rm -rf "${compile_directory:?}"/
current_bitcoin_version="${target_bitcoin_version}"
else
printf '%s\n' "not found."
Expand Down