net: make CNode::m_inbound_onion public, initialize explicitly #21167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and to allow the compiler to warn if uninitialized in the ctor or omitted in the caller.
jonatack
commented
Feb 12, 2021
| nKeyedNetGroup(nKeyedNetGroupIn), | ||
| id(idIn), | ||
| nLocalHostNonce(nLocalHostNonceIn), | ||
| m_conn_type(conn_type_in), | ||
| nLocalServices(nLocalServicesIn), | ||
| m_inbound_onion(inbound_onion) | ||
| nLocalServices(nLocalServicesIn) |
There was a problem hiding this comment.
Argument order changed for -Wreorder initialization order (in this case public members first, then private)
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Feb 13, 2021
vasild
approved these changes
Feb 15, 2021
|
review ACK 2ee4a7a 🏀 Show signature and timestampSignature: Timestamp of file with hash |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 15, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 4, 2022
Summary: > net: make CNode::m_inbound_onion public, drop getter, update tests > net: remove CNode::m_inbound_onion defaults for explicitness > > and to allow the compiler to warn if uninitialized in the ctor > or omitted in the caller. This is a backport of [[bitcoin/bitcoin#21167 | core#21167]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10973
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring only, no change in behavior. This is a quick follow-up to #20210 to address these review comments:
Changes:
CNode::m_inbound_onion classmember public, update the Doxygen comment, drop the getter, and update the testsCNode::m_inbound_oniondefault value initialization in the ctor declaration and the member initializer in favor of always passing it explicitly to the ctor where we initialize it dynamically, to both clarify the caller code and to allow the compiler to warn if it is uninitialized in the ctor or omitted in the caller