miner: empty mempool special case for waitNext() #33566
Open
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33566. ReviewsSee the guideline for information on the review process. |
|
This is not worth the effort to backport imo. |
Sjors
force-pushed
the
2025/10/wait-empty-mempool
branch
from
f680aa7 to
54db166
Compare
Block template fees are calculated by looping over new_tmpl->vTxFees and return (early) once the fee_threshold is exceeded. This left an edge case when the mempool is empty, which this commit fixes and adds a test for. Also update interface_ipc.py to account for the new behavior.
Sjors
force-pushed
the
2025/10/wait-empty-mempool
branch
from
54db166 to
2e8fff3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block template fees are calculated by looping over
new_tmpl->vTxFeesand return (early) once thefee_thresholdis exceeded.This left an edge case when the mempool is empty, which this commit fixes and adds a test for.
Also update
test/functional/interface_ipc.pyto reflect the new behavior,Fixes Sjors/sv2-tp#9