Define 7200 second timestamp window constant #9908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
changed the title
maflcko
changed the title
laanwj
reviewed
Mar 3, 2017
src/chain.h
Outdated
| * to block timestamps. This should be set at least as high as | ||
| * MAX_FUTURE_BLOCK_TIME. | ||
| */ | ||
| static const int64_t TIMESTAMP_WINDOW = MAX_FUTURE_BLOCK_TIME; |
There was a problem hiding this comment.
Isn't this a wallet constant?
No, it's also used by the pruneblockchain RPC (#9778).
|
utACK 3b8d451 |
paveljanik
reviewed
Mar 3, 2017
src/chain.h
Outdated
|
|
||
| /** | ||
| * Timestamp window used as a grace period by code that compares external | ||
| * timestamps (such as timestamps passed to RPCS, or wallet key creation times) |
There was a problem hiding this comment.
Sure, changed in de41344
ryanofsky
commented
Mar 3, 2017
src/chain.h
Outdated
|
|
||
| /** | ||
| * Timestamp window used as a grace period by code that compares external | ||
| * timestamps (such as timestamps passed to RPCS, or wallet key creation times) |
There was a problem hiding this comment.
Sure, changed in de41344
|
ACK e57a1fd |
laanwj
added a commit
that referenced
this pull request
Mar 6, 2017
e57a1fd Define 7200 second timestamp window constant (Russell Yanofsky) Tree-SHA512: 449d20e4fd23905cd96be36f717c55a0a2360aba1002aaf55a3699cce4a41f6e94acc2fbe511a93c5cbe8f8e68386995a76cad67620ebb66ba9283e6080ab567
jtimon
reviewed
Mar 23, 2017
| * Maximum amount of time that a block timestamp is allowed to exceed the | ||
| * current network-adjusted time before the block will be accepted. | ||
| */ | ||
| static const int64_t MAX_FUTURE_BLOCK_TIME = 2 * 60 * 60; |
There was a problem hiding this comment.
This one belongs in consensus/consensus.h
There was a problem hiding this comment.
This one belongs in consensus/consensus.h
I don't have an opinion, but when I discussed this with @morcos a while ago, I think he suggested it shouldn't go there because it isn't a constant that needs to be exactly the same everywhere to have consensus.
codablock
added a commit
to codablock/dash
that referenced
this pull request
Jan 26, 2018
Until Bitcoin bitcoin#9908 gets backported
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
Until Bitcoin bitcoin#9908 gets backported
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 21, 2019
e57a1fd Define 7200 second timestamp window constant (Russell Yanofsky) Tree-SHA512: 449d20e4fd23905cd96be36f717c55a0a2360aba1002aaf55a3699cce4a41f6e94acc2fbe511a93c5cbe8f8e68386995a76cad67620ebb66ba9283e6080ab567
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 21, 2019
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 25, 2019
e57a1fd Define 7200 second timestamp window constant (Russell Yanofsky) Tree-SHA512: 449d20e4fd23905cd96be36f717c55a0a2360aba1002aaf55a3699cce4a41f6e94acc2fbe511a93c5cbe8f8e68386995a76cad67620ebb66ba9283e6080ab567
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 25, 2019
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 25, 2019
e57a1fd Define 7200 second timestamp window constant (Russell Yanofsky) Tree-SHA512: 449d20e4fd23905cd96be36f717c55a0a2360aba1002aaf55a3699cce4a41f6e94acc2fbe511a93c5cbe8f8e68386995a76cad67620ebb66ba9283e6080ab567
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 25, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
Until Bitcoin bitcoin#9908 gets backported
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.