Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Handle the result of posix_fallocate system call #15650
Do you think we can consider the Linux part in the fallback? I don't know if posix_allocate can be called on every platform. It will become something like:
This way the system call
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Just tested on an affected filesystem (unionf on Debian stable), using strace to check the system calls sent to the system. The success return value of posix_fallocate is obviously zero. Somehow in a previous version I had the '!', but then I pushed the wrong one, without it. I've just force-pushed the good version, I've just tested with strace.
Affected filesystem (fallocate result is EOPNOTSUPP, and the fallback code is activated):
Ext4 filesystem (fallocate result is zero, that means success, and no other code is activated):
Mar 23, 2019
Gitian builds for commit 7b13c64 (master):
Gitian builds for commit a48eb1b (master and this pull):