Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix typos in COPYRIGHT #16615

Merged
merged 1 commit into from
Aug 15, 2019
Merged

doc: Fix typos in COPYRIGHT #16615

merged 1 commit into from
Aug 15, 2019

Conversation

GChuf
Copy link
Contributor

@GChuf GChuf commented Aug 14, 2019

Fixed a couple of typos

Fixed a couple of typos
@fanquake fanquake added the Docs label Aug 14, 2019
@maflcko
Copy link
Member

maflcko commented Aug 14, 2019

ACK. Correct name is indeed "Stephen Hutchings"

@maflcko maflcko added this to the 0.18.2 milestone Aug 14, 2019
@hebasto
Copy link
Member

hebasto commented Aug 14, 2019

Correct name is indeed "Stephen Hutchings"

Has he an account on the GutHub?

@laanwj
Copy link
Member

laanwj commented Aug 14, 2019

ACK. Correct name is indeed "Stephen Hutchings"

I was looking for conclusive source on this but couldn't find it

@GChuf
Copy link
Contributor Author

GChuf commented Aug 14, 2019

https://github.com/stephenhutchings
https://stephenhutchings.com/
https://www.s-ings.com/me/

@emilengler
Copy link
Contributor

Concept ACK

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #16612 (qt: Remove menu icons by laanwj)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 36f7697, correct name is already here:

Copyright: Stephen Hutchings (and more)

All occurrences are now correct.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 36f7697

@fanquake fanquake merged commit 36f7697 into bitcoin:master Aug 15, 2019
fanquake added a commit that referenced this pull request Aug 15, 2019
36f7697 doc: Fix typos in COPYRIGHT (Chuf)

Pull request description:

  Fixed a couple of typos

ACKs for top commit:
  promag:
    ACK 36f7697, correct name is already here:
  fanquake:
    ACK 36f7697

Tree-SHA512: 9da498403667f6200669abc0a7fc110e6d2205b577743d412e18d7718016707181ca65f6660dda085c252808b77b1573dfab246ca9c3adfbe97f790d5bee9615
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Aug 15, 2019
Fixed a couple of typos

Github-Pull: bitcoin#16615
Rebased-From: 36f7697
@fanquake fanquake mentioned this pull request Aug 15, 2019
@GChuf GChuf deleted the patch-1 branch August 16, 2019 13:08
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Aug 24, 2019
Fixed a couple of typos

Github-Pull: bitcoin#16615
Rebased-From: 36f7697
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Sep 23, 2019
Fixed a couple of typos

Github-Pull: bitcoin#16615
Rebased-From: 36f7697
laanwj added a commit that referenced this pull request Nov 25, 2019
0b18ea6 util: Filter control characters out of log messages (Wladimir J. van der Laan)
ac30fc4 build: Factor out qt translations from build system (Wladimir J. van der Laan)
3b8af5f build: update boost macros to latest upstream (fanquake)
b12defc Test that joinpsbts randomly shuffles the inputs (Andrew Chow)
eb07d22 Shuffle inputs and outputs after joining psbts (Andrew Chow)
1175410 addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests. (practicalswift)
c52dd12 Handle the result of posix_fallocate system call (Luca Venturini)
f792b25 torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently (Luke Dashjr)
9fe8d28 Bugfix: QA: Run tests with UPnP disabled (Luke Dashjr)
1d12e52 Add vertical spacer (Josu Goñi)
d764141 depends: add patch to common dependencies (fanquake)
56815e9 Give QApplication dummy arguments (Andrew Chow)
9d389d0 util: No translation of `Bitcoin Core` in the copyright (MarcoFalke)
87908e9 scripted-diff: Avoid passing PACKAGE_NAME for translation (MarcoFalke)
a44e18f build: Stop translating PACKAGE_NAME (MarcoFalke)
7bd8f4e rpc: Fix getblocktemplate CLI example (#16594) (Emil Engler)
1cc06a1 doc: Fix typos in COPYRIGHT (Chuf)

Pull request description:

  Backports some commits to the `0.18` branch:

  * #16596 - rpc: Fix getblocktemplate CLI example
  * #16615 - doc: Fix typos in COPYRIGHT
  * #16291 - gui: Stop translating PACKAGE_NAME (without the `make translate` commit)
  * #16578 - Do not pass in command line arguments to QApplication
  * #16051 - depends: add patch to common dependencies
  * #16090 - Add vertical spacer
  * #15651 - torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently
  * #15650 - Handle the result of posix_fallocate system call
  * #16646 - Bugfix: QA: Run tests with UPnP disabled
  * #16212 - addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests.
  * #16512 - rpc: Shuffle inputs and outputs after joining psbts
  * #16870 - build: update boost macros to latest upstream for improved error reporting
  * #16982 - build: Factor out qt translations from build system
  * #17095 - util: Filter control characters out of log messages

ACKs for top commit:
  laanwj:
    ACK 0b18ea6

Tree-SHA512: 37f0e5afc20975f4d1506e8662eda2ae0125f2f424a852818b5af2c3b8db78fc1c365b83571aa80ca63c885ca314302190b891a50ff3851fda9b9238455a5627
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 13, 2020
Summary:
Fixed a couple of typos
Backport of Core [[bitcoin/bitcoin#16615 | PR16615]]

Test Plan: Googled `Stephen Hutchings`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7903
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants