Add a few test cases to data-driven script tests and add data-driven transaction tests. #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quick ACK (== I scrolled through them for a sanity check, but did not stare hard at each one) |
|
The following is an automatic comment from the Bitcoin Pull Tester. This pull passed automatic sanity-tests! |
|
Temporarily closing to add more tests which are waiting to push. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/da9e86c3b6cfdd13ed71744a082df94de1f3f41f for binaries and test log. |
|
ACK (compiles and runs nicely on my Mac) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are largely useless, but they do double-check a few things that could be useful for new implementations.
(and quite a few of them are duplicated, but I don't feel like looking into which ones).
Now with data-driven transaction tests which consist of a list of inputs, and a serialized transaction.
Again, the data-driven transaction tests are more targeted at alternative implementations than the reference client.
Also pulled in a commit to make test_bitcoin useful when it fails (otherwise you have no idea why it failed, it just says failed and you have to scroll back through a ton of crap to find it).