Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bitcoin to use OpenSSL 1.0.1c #1837

Closed
wants to merge 4 commits into from
Closed

Update Bitcoin to use OpenSSL 1.0.1c #1837

wants to merge 4 commits into from

Conversation

fanquake
Copy link
Member

I noticed that 0.7.0 for OSX is compiled with 1.0.1c, so I thought it might be an idea to update the makefiles, readme etc. I'm assuming that theres no reason that unix and windows builds cannot use 1.0.1b.

@Diapolo
Copy link

Diapolo commented Sep 19, 2012

I've been using 1.0.1c for my own Windows builds for months and have not found any problems with it.

@@ -24,7 +24,7 @@ Dependencies
Libraries you need to download separately and build:

default path download
OpenSSL \openssl-1.0.1b-mgw http://www.openssl.org/source/
OpenSSL \openssl-1.0.1c-mgw http://www.openssl.org/source/
Berkeley DB \db-4.8.30.NC-mgw http://www.oracle.com/technology/software/products/berkeley-db/index.html
Boost \boost-1.47.0-mgw http://www.boost.org/users/download/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are at 1.50 for Windows AFAIK? Perhaps you can create another small patch for this.

@Diapolo
Copy link

Diapolo commented Sep 19, 2012

Thanks :), looks good.

@BitcoinPullTester
Copy link

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/b7a8802c2acd61394b63856d7ff7ca942df81a00 for binaries and test log.

This could happen for one of several reasons:

  1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
  2. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
  3. The test suite fails on either Linux i386 or Win32
  4. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

@laanwj
Copy link
Member

laanwj commented Sep 20, 2012

Please increase the deps version number, ie to bitcoin-deps-0.0.5.zip (both in deps-win32.yml and gitian-win32.yml)

@BitcoinPullTester
Copy link

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/05c1c08e295f067a5fbd32fb7ad80fe01d2aa49d for binaries and test log.

This could happen for one of several reasons:

  1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
  2. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
  3. The test suite fails on either Linux i386 or Win32
  4. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

@laanwj
Copy link
Member

laanwj commented Sep 21, 2012

Ok great,

Looks like @TheBlueMatt's has to install openssl1.0.1c in /mnt/mingw/openssl-1.0.1c, before the pull tester can test this.

Berkeley DB 4.8.30.NC
Boost 1.47.0
Boost 1.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1.5.0 is not the same thing as 1.50.0.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, should be 1.50.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'll correct that

@BitcoinPullTester
Copy link

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/9cde889992e16527c99c262831292b944a2faabe for binaries and test log.

This could happen for one of several reasons:

  1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
  2. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
  3. The test suite fails on either Linux i386 or Win32
  4. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

@fanquake
Copy link
Member Author

Closing this.
Will merge all into a single commit in a new pull.

@fanquake fanquake closed this Sep 22, 2012
@laanwj
Copy link
Member

laanwj commented Sep 22, 2012

You don't need to close your pull for that. You can just "rebase -i", squash the commits and push -f to the current branch.

@fanquake
Copy link
Member Author

I would have. But those commits were in the master branch, instead of a separate one. I've been meaning to start using branches for pulls for a while now, so thought I might just sort myself out and do that instead.

@TheBlueMatt
Copy link
Contributor

1.0.0c build for pull-tester, should test properly now.

KolbyML pushed a commit to KolbyML/bitcoin that referenced this pull request Dec 5, 2020
c2fe843 Use Optional template in guiinterface.h (Kolby Moroz Liebl)

Pull request description:

  The rest of the codebase has switched to using a template of boost::optional instead, this is the only part which still uses boost::optional instead of the template added for it

ACKs for top commit:
  random-zebra:
    utACK c2fe843
  furszy:
    utACK c2fe843

Tree-SHA512: 93587ced06e7dad57784a52e4344035354f90df7d97deafc69ad1bf1f9f467fdf7e91df208168a6ef0f8d4174d202fa3c7cf16695b8f42b37ecb400abd968aef
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants