Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable GCC large address aware linker flag (Windows only) #2167

Merged
merged 1 commit into from
Jan 23, 2013
Merged

enable GCC large address aware linker flag (Windows only) #2167

merged 1 commit into from
Jan 23, 2013

Conversation

Diapolo
Copy link

@Diapolo Diapolo commented Jan 10, 2013

  • this flag allows bitcoin-qt.exe / bitcoind.exe (32-bit application) to
    handle addresses larger than 2GB (up to 3GB on x86 Windows and up to
    4GB on x64 Windows)

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a35a8e3219e933265b0e34f7c72e08ed33ac0f63 for binaries and test log.

@sipa
Copy link
Member

sipa commented Jan 13, 2013

From what I read, this simply tells the OS that the application is prepared to deal with a >2GB address range. Not all Windows OSs/platforms support it, but enabling this flag should be a no-op for those.

If someone can verify binaries built with this still work on a 32-bit XP, I'm fine with merging this.

- this flag allows bitcoin-qt.exe / bitcoind.exe (32-bit application) to
  handle addresses larger than 2GB (up to 3GB on x86 Windows and up to
  4GB on x64 Windows)
@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1f0ce2dd68313094af7cf6647bdf5936bee8352c for binaries and test log.

@Diapolo
Copy link
Author

Diapolo commented Jan 17, 2013

@sipa I'm going to try the pulltester binary with WinXP tomorrow :).

@Diapolo
Copy link
Author

Diapolo commented Jan 18, 2013

@sipa Did an IBD with bitcoin-qt.exe, tried a wallet encryption and there were no errros, the client started and closed just fine as expected. Btw. it seems @BitcoinPullTester is using an older OpenSSL version then we do with Gitian.

gavinandresen added a commit that referenced this pull request Jan 23, 2013
enable GCC large address aware linker flag (Windows only)
@gavinandresen gavinandresen merged commit 5a4af8f into bitcoin:master Jan 23, 2013
laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
enable GCC large address aware linker flag (Windows only)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants