Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Bump shellcheck version #21749

Merged
merged 1 commit into from
May 10, 2021
Merged

test: Bump shellcheck version #21749

merged 1 commit into from
May 10, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 22, 2021

The changelog for v0.7.2 is available here.

Only SC2268 requires to update our code.

@fanquake fanquake added the Tests label Apr 22, 2021
@hebasto hebasto marked this pull request as ready for review April 22, 2021 09:19
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift
Copy link
Contributor

Concept ACK

Nice to see unnecessary ancient x-prefix cruft ("x$1" = "x") go.

@kiminuo
Copy link
Contributor

kiminuo commented Apr 24, 2021

Concept ACK

The changelog shows minor useful changes.

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 08f3dbb

Patch looks correct and CI is green.

grabbed 0.7.2 and ran linter locally with no problem on linux.

@laanwj laanwj merged commit 1a60c54 into bitcoin:master May 10, 2021
@hebasto hebasto deleted the 210422-shell branch May 10, 2021 12:53
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 10, 2021
08f3dbb test: Bump shellcheck version (Hennadii Stepanov)

Pull request description:

  The changelog for v0.7.2 is available [here](https://github.com/koalaman/shellcheck/blob/v0.7.2/CHANGELOG.md).

  Only [SC2268](https://github.com/koalaman/shellcheck/wiki/SC2268) requires to update our code.

ACKs for top commit:
  jarolrod:
    ACK  08f3dbb

Tree-SHA512: 4585cd1f4d9def2fbaafe5a2a57761288d432781eb8c6c6d37064727d7ca8fc3f35c552e6a2ffdf0820d753d4bde2c8e43e5f3f57d242f5f57591a9b1b03558d
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants