-
Notifications
You must be signed in to change notification settings - Fork 36.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Avoid passing params where not needed #25168
The head ref may contain hidden characters: "2205-remove-bloat-\u{1F3EE}"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK fa1b76a
Concept ACK |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Code review ACK fa1b76a. |
post-merge ACK. This synergizes well with some of the upcoming |
It seems confusing to pass chain params, consensus params, or a time function around when it is not needed.
Fix this by:
chainman.GetConsensus()
orchainman.GetParams()
, where possible.