build: Re-enable external signer on Windows #25696

hebasto · 2022-07-25T13:41:12Z

As boostorg/process#207 has been resolved, it is possible now to re-enable external signer on Windows when cross-compiling.

Guix build hashes:

78f69ea7e0dbc8338981a92c0352220ccd7c2272d8cbff6a3b082a1412a935c5  guix-build-1a0d8e178c7b/output/aarch64-linux-gnu/SHA256SUMS.part
ee17456ec818ddf5a175182508966e622573ccb518807cca43a40fa1dceda092  guix-build-1a0d8e178c7b/output/aarch64-linux-gnu/bitcoin-1a0d8e178c7b-aarch64-linux-gnu-debug.tar.gz
5080551bde379c746cc67b10429aef33b9f9e49d2d4e21ee1c3bfd9c1c845d46  guix-build-1a0d8e178c7b/output/aarch64-linux-gnu/bitcoin-1a0d8e178c7b-aarch64-linux-gnu.tar.gz
dfab220ce76a40bf7dcf07aab352a616a91b516503639455fe7e1b137bad3e85  guix-build-1a0d8e178c7b/output/arm-linux-gnueabihf/SHA256SUMS.part
516ceb822571a8bd88fe107dca434ef596b1e4328ccbda1d51e1d482d3050396  guix-build-1a0d8e178c7b/output/arm-linux-gnueabihf/bitcoin-1a0d8e178c7b-arm-linux-gnueabihf-debug.tar.gz
21325380638f817107c203b9a1aedb808d1a4a2b4041493753ca4cbf19aa4f2c  guix-build-1a0d8e178c7b/output/arm-linux-gnueabihf/bitcoin-1a0d8e178c7b-arm-linux-gnueabihf.tar.gz
cf48ed78fcfceaeb3610ccf22326d735a129dcbf9d50b557b3de359169aefdfd  guix-build-1a0d8e178c7b/output/arm64-apple-darwin/SHA256SUMS.part
d4d51e136148bac6a20bb3adb402c499967647736acb420bfdeb71603aba57da  guix-build-1a0d8e178c7b/output/arm64-apple-darwin/bitcoin-1a0d8e178c7b-arm64-apple-darwin-unsigned.dmg
95bb62d24f860e08a392ddb74d5860ccf27e8baa183e6749af877d26a3bd6b0b  guix-build-1a0d8e178c7b/output/arm64-apple-darwin/bitcoin-1a0d8e178c7b-arm64-apple-darwin-unsigned.tar.gz
68da4c92f37bb802df37141af194f47c16da1d84f77a0fbb1016013ae0338502  guix-build-1a0d8e178c7b/output/arm64-apple-darwin/bitcoin-1a0d8e178c7b-arm64-apple-darwin.tar.gz
6704e38c2d3f11321403797598d05f062648fec6f2d76900ba250dab481e29da  guix-build-1a0d8e178c7b/output/dist-archive/bitcoin-1a0d8e178c7b.tar.gz
64b936bc90d1e01fe8f276511edc9bb945dcebe70332aa37d3a786348443b8e7  guix-build-1a0d8e178c7b/output/powerpc64-linux-gnu/SHA256SUMS.part
3d03532e54b6e42498ea240c86b8567e94fd462f56087b869c3d6f09e2dde878  guix-build-1a0d8e178c7b/output/powerpc64-linux-gnu/bitcoin-1a0d8e178c7b-powerpc64-linux-gnu-debug.tar.gz
c5843d79a58b0a864fe723458dab4eee54ad11f4b1f7960975b086eeedc0d541  guix-build-1a0d8e178c7b/output/powerpc64-linux-gnu/bitcoin-1a0d8e178c7b-powerpc64-linux-gnu.tar.gz
f861ff519bd5e3d6d5ce1646ee0a06bcef1288ddb804a4a600e4dbfe5d5be521  guix-build-1a0d8e178c7b/output/powerpc64le-linux-gnu/SHA256SUMS.part
5f477da21980dbcf9696081903dc1ba8a3f79ce3579641d208e69a6f598c8eb9  guix-build-1a0d8e178c7b/output/powerpc64le-linux-gnu/bitcoin-1a0d8e178c7b-powerpc64le-linux-gnu-debug.tar.gz
b3757b11c614136934158acea5139e8abd0c5c9cdfda72ae44db436f21716b33  guix-build-1a0d8e178c7b/output/powerpc64le-linux-gnu/bitcoin-1a0d8e178c7b-powerpc64le-linux-gnu.tar.gz
1c21bdb17fe3436e685e88c62423e630fe2b3c41dd00025a99fd80d97817ac2f  guix-build-1a0d8e178c7b/output/riscv64-linux-gnu/SHA256SUMS.part
f36ae98473f086ae8f0dc66223b5ec407d57dc4d8d45ae284401520ff5c0b273  guix-build-1a0d8e178c7b/output/riscv64-linux-gnu/bitcoin-1a0d8e178c7b-riscv64-linux-gnu-debug.tar.gz
1603e4d0e869eb47a1dc2d26b67772d0016d90f7ba5e50d2009365cc02cb8169  guix-build-1a0d8e178c7b/output/riscv64-linux-gnu/bitcoin-1a0d8e178c7b-riscv64-linux-gnu.tar.gz
f86ef652102f022827b70477bffa0a44008c6300cf62ca7b3595146cf2ed91ba  guix-build-1a0d8e178c7b/output/x86_64-apple-darwin/SHA256SUMS.part
f84d435d8e4709bf29bc7ac7ed8dc6b8af4077cef05e520b468b2896ce10876a  guix-build-1a0d8e178c7b/output/x86_64-apple-darwin/bitcoin-1a0d8e178c7b-x86_64-apple-darwin-unsigned.dmg
af2aab969b7ed7aeea0e02adbcc9e3b438086bf76b6bfc36146c53e05a27bd57  guix-build-1a0d8e178c7b/output/x86_64-apple-darwin/bitcoin-1a0d8e178c7b-x86_64-apple-darwin-unsigned.tar.gz
32a5109ba28ab74ff66238e6a8f8a04e455ebce382a3be287df92a227818fe72  guix-build-1a0d8e178c7b/output/x86_64-apple-darwin/bitcoin-1a0d8e178c7b-x86_64-apple-darwin.tar.gz
377462e9a96f4aba72c915dd5df5159a4301a1fa8ed0ee48faa6c71573de80c3  guix-build-1a0d8e178c7b/output/x86_64-linux-gnu/SHA256SUMS.part
a3bf62e828d2350a483b2d16205014f66e8884597b0b72e178042a958c548336  guix-build-1a0d8e178c7b/output/x86_64-linux-gnu/bitcoin-1a0d8e178c7b-x86_64-linux-gnu-debug.tar.gz
66cda980188ea1941a7d66c8b03c447580af33db55abe3bbe3581823ae0534a3  guix-build-1a0d8e178c7b/output/x86_64-linux-gnu/bitcoin-1a0d8e178c7b-x86_64-linux-gnu.tar.gz
2117f0dd9baeb4d585f841592e94c088f4487bf2008b8f281d0c3ceee92ff6cc  guix-build-1a0d8e178c7b/output/x86_64-w64-mingw32/SHA256SUMS.part
d40d5dec3287f467c42232c05d82f7fb538cda34bd2e63ff7e1876f471c3a790  guix-build-1a0d8e178c7b/output/x86_64-w64-mingw32/bitcoin-1a0d8e178c7b-win64-debug.zip
92dcc92765fbc07b1cc8258bfa69280541e1b4553cc41fed18672c2c6931d5c0  guix-build-1a0d8e178c7b/output/x86_64-w64-mingw32/bitcoin-1a0d8e178c7b-win64-setup-unsigned.exe
a6dd9b4d29f21d3a18cf64556cb03446ef17bf801eb6ac257b65d27cbd95080f  guix-build-1a0d8e178c7b/output/x86_64-w64-mingw32/bitcoin-1a0d8e178c7b-win64-unsigned.tar.gz
a4022e595d955198f73530473ef8e90a708746089ee2dd27de794176873330c1  guix-build-1a0d8e178c7b/output/x86_64-w64-mingw32/bitcoin-1a0d8e178c7b-win64.zip

configure.ac

DrahtBot · 2022-07-25T18:26:10Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	Sjors, achow101
Stale ACK	jarolrod

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#24742 (build: prune Boost headers in depends by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake · 2022-07-27T14:10:42Z

Similar to #25111. I'm still ~0 on this change, but this approach is an improvement.

Given #24907, I don't think we should be leaning back into more Boost code usage. Outside of that, it's pretty clear that Boost Process currently has no or minimal support for mingw-w64 builds. It looks like they don't even have a mingw-w64 build in their CI (only MSVC). Windows fixes, some that we've upstreamed, also remain ignored, i.e boostorg/process#237, boostorg/process#239, boostorg/process#240.

I assume if we make this change, external signing on Windows is only going to be supported with Boost 1.80.0 and later? If so, I assume we can remove

bitcoin/src/test/system_tests.cpp

Line 10 in 207a228

#if defined(WIN32) && !defined(__kernel_entry)

?

hebasto · 2022-07-27T19:47:51Z

@fanquake

I assume if we make this change, external signing on Windows is only going to be supported with Boost 1.80.0 and later? If so, I assume we can remove

bitcoin/src/test/system_tests.cpp

Line 10 in 207a228

#if defined(WIN32) && !defined(__kernel_entry)

Correct. See #25723.

ba9a8e6 test: Drop unused boost workaround (Hennadii Stepanov) Pull request description: This PR is a follow up of bitcoin/bitcoin#24065 and removes the workaround which has already been removed in other [places](https://github.com/bitcoin/bitcoin/pull/24065/files#diff-19427b0dd1a791adc728c82e88f267751ba4f1c751e19262cac03cccd2822216). Moreover, this workaround won't be required even if bitcoin/bitcoin#25696 is ever merged. ACKs for top commit: fanquake: ACK ba9a8e6 Tree-SHA512: db19fc1550252d7a82a08f388ff6078c78452365e74b41e7bc36cbbc4d0fed9342636e8f2371bb8e78c9d11ee721d6363bcc21d11787f3aac967a6c4a9cc346f

hebasto · 2022-07-28T11:03:54Z

Rebased on top of #25723.

ba9a8e6 test: Drop unused boost workaround (Hennadii Stepanov) Pull request description: This PR is a follow up of bitcoin#24065 and removes the workaround which has already been removed in other [places](https://github.com/bitcoin/bitcoin/pull/24065/files#diff-19427b0dd1a791adc728c82e88f267751ba4f1c751e19262cac03cccd2822216). Moreover, this workaround won't be required even if bitcoin#25696 is ever merged. ACKs for top commit: fanquake: ACK ba9a8e6 Tree-SHA512: db19fc1550252d7a82a08f388ff6078c78452365e74b41e7bc36cbbc4d0fed9342636e8f2371bb8e78c9d11ee721d6363bcc21d11787f3aac967a6c4a9cc346f

depends/patches/boost/mingw32_process.patch

Sjors · 2022-08-05T08:27:47Z

I can't test on Windows. Bumping the Boost version in depends should probably be its own PR? (or at least indicated in the PR description)

fanquake · 2022-08-19T09:35:49Z

Bumping the Boost version in depends should probably be its own PR?

See #25873.

hebasto · 2022-08-19T10:47:29Z

Updated 0444353 -> 9077916 (pr25696.04 -> pr25696.05):

rebased on top of the depends: Boost 1.80.0 #25873
a patch replaced with the upstream one
undrafted

jarolrod · 2022-09-14T04:29:02Z

concept ack

guix hashes

x86:

a4a230812d5e8281be4c1a96689ca64e917110a780bd96b254122d2588dba3d0  guix-build-86cb0b7168a2/output/dist-archive/bitcoin-86cb0b7168a2.tar.gz
2ad6d601394435946daf51e000af396ebbc89dfee8a10a76698ba2084c88b9a7  guix-build-86cb0b7168a2/output/x86_64-w64-mingw32/SHA256SUMS.part
d6f2efe1e0b5be2ad4b465c078d36cdf636713049a60a2b424c3a9a16a667c1a  guix-build-86cb0b7168a2/output/x86_64-w64-mingw32/bitcoin-86cb0b7168a2-win64-debug.zip
b29537c5bdc6d1cbd03be251f039d61f8f5215853fd47d776d05d85907aeb838  guix-build-86cb0b7168a2/output/x86_64-w64-mingw32/bitcoin-86cb0b7168a2-win64-setup-unsigned.exe
6349e6a21671ec8f1dbcd76a6246ec0300384864d198bb768dce1d853b2bc115  guix-build-86cb0b7168a2/output/x86_64-w64-mingw32/bitcoin-86cb0b7168a2-win64-unsigned.tar.gz
52192555fde11182b50758fd23db112e7a6a152e7c78b935da45ab2840021b61  guix-build-86cb0b7168a2/output/x86_64-w64-mingw32/bitcoin-86cb0b7168a2-win64.zip

arm64:

a4a230812d5e8281be4c1a96689ca64e917110a780bd96b254122d2588dba3d0  guix-build-86cb0b7168a2/output/dist-archive/bitcoin-86cb0b7168a2.tar.gz
2ad6d601394435946daf51e000af396ebbc89dfee8a10a76698ba2084c88b9a7  guix-build-86cb0b7168a2/output/x86_64-w64-mingw32/SHA256SUMS.part
d6f2efe1e0b5be2ad4b465c078d36cdf636713049a60a2b424c3a9a16a667c1a  guix-build-86cb0b7168a2/output/x86_64-w64-mingw32/bitcoin-86cb0b7168a2-win64-debug.zip
b29537c5bdc6d1cbd03be251f039d61f8f5215853fd47d776d05d85907aeb838  guix-build-86cb0b7168a2/output/x86_64-w64-mingw32/bitcoin-86cb0b7168a2-win64-setup-unsigned.exe
6349e6a21671ec8f1dbcd76a6246ec0300384864d198bb768dce1d853b2bc115  guix-build-86cb0b7168a2/output/x86_64-w64-mingw32/bitcoin-86cb0b7168a2-win64-unsigned.tar.gz
52192555fde11182b50758fd23db112e7a6a152e7c78b935da45ab2840021b61  guix-build-86cb0b7168a2/output/x86_64-w64-mingw32/bitcoin-86cb0b7168a2-win64.zip

cc8dff5 depends: Boost 1.80.0 (fanquake) Pull request description: Mostly misc bug fixes and improvements, to the continually decreasing parts of Boost that we actually use. See: https://www.boost.org/users/history/version_1_80_0.html. Includes some boring upstreamed changes, i.e boostorg/multi_index#57, boostorg/signals2#60 that aid #24742. Getting Boost modules to drop their usage of deprecated (redirect) headers means we can prune them from our depends tree. Also a requirement for #25696. Guix Build (x86_64): ```bash e793a5ac9372b8fce6e19916be840eee99735bccdedf44b9bca006fd9ac8c395 guix-build-cc8dff5f8ff8/output/aarch64-linux-gnu/SHA256SUMS.part 001e0382f2b05e12f0ec5eaf09e001e31313ee3ab5367b0ba135ea2d7b863bf6 guix-build-cc8dff5f8ff8/output/aarch64-linux-gnu/bitcoin-cc8dff5f8ff8-aarch64-linux-gnu-debug.tar.gz a50229534b41eebd6c44001b56eb2be35b50d5f3a3b161a8fa46d7558b79693e guix-build-cc8dff5f8ff8/output/aarch64-linux-gnu/bitcoin-cc8dff5f8ff8-aarch64-linux-gnu.tar.gz d54d16ae4d5ef2bb0d0dcebbd6d1ec4b0f0976063bf66222a320e68340f902d5 guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/SHA256SUMS.part 04c464043af256ee05d565040df9bb438151d4e041aa46f800fc567eba111c2f guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/bitcoin-cc8dff5f8ff8-arm-linux-gnueabihf-debug.tar.gz 097cd2f633bf6d3b8e922d81ce9f6dfe793589418e394abfa4e183861f5ad236 guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/bitcoin-cc8dff5f8ff8-arm-linux-gnueabihf.tar.gz 30c8074725b0701b1a781685f50a23ba038297b2633599f40792157daadc13cb guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/SHA256SUMS.part df6036e89c7e8746badcbcf805ec4f84070847833c562bc2185c15904b1b909a guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin-unsigned.dmg 8421c957b2b83c4afc3bc7f65f93798755acc99ac5921bd89b367c22c5b064d8 guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin-unsigned.tar.gz 076e8e185bc01dd43feb3fcbcec04eff5ca435b0fdf47c6f05008feec1cf11ac guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin.tar.gz 03de7ffcf8d98c61c3a5b763e9bcc6310c9895950f49768da2eeba4871d8478a guix-build-cc8dff5f8ff8/output/dist-archive/bitcoin-cc8dff5f8ff8.tar.gz 80ffe674a5fa86cfcf3f47eb8103dbfbc97dd74f793cf785c1347469f19b281f guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/SHA256SUMS.part 8ce2024c3fa65e6cd613ef526f90c5904675012b22eb39ccf94081d91e14340a guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64-linux-gnu-debug.tar.gz 89dc31c0306b0f1c79e13e5f705b73233695a802fd4946aac03364c45e7de984 guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64-linux-gnu.tar.gz 7ed1b82ba3d4c1a8ddc24c6f650aa6b2d1be08580b2ec32cfec0fd682828d797 guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/SHA256SUMS.part 01c7f706b236b342f4e0b5043c5788168806338cdaefd5541b04118665c7e40b guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64le-linux-gnu-debug.tar.gz 01767af5b190d0be4a075a5d038644b7dd0d1fc5f0b69698acaca92bfef960d0 guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64le-linux-gnu.tar.gz 414de662e0bb3df6a5c8fc1a3576c90a943998b802d97070e31bde434fc6a7f1 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/SHA256SUMS.part db55ddf8051e6dc80180f3eee12a7370bed1140959c34fb5de8d88f0344b23e2 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/bitcoin-cc8dff5f8ff8-riscv64-linux-gnu-debug.tar.gz bb19f15545d5a52e800ffb7f141915ab7083fb4fab9a80269f6714b28a294502 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/bitcoin-cc8dff5f8ff8-riscv64-linux-gnu.tar.gz d9241782d6e596ae02500ffe062501f80b064357bece5d10f7fd4d218240c3a1 guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/SHA256SUMS.part 1c3258a573e849a8efe6fce535a4f8737fb3a076ebe74ee29ca1e84a9113d24f guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin-unsigned.dmg 7e6d562dd636fcacae88bedca45b49a879901c0fc1309ea1812aba59bbbcb5d0 guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin-unsigned.tar.gz c4bc9c27466504417a4bd581cc024b8c5a370a51c8349c1f067752c98c2c14bc guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin.tar.gz 59aaf11181373efd2e281004ce968967a26fa95f90c5a25f44cc4c687e9ddb0a guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/SHA256SUMS.part fbcde4bfe21314104c7e6036e1f7f4b3ef0e41a7546fef5d1f2a6456b955778d guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/bitcoin-cc8dff5f8ff8-x86_64-linux-gnu-debug.tar.gz b1302146a0e96f7faa150d764aa0ca92b46e887a886532ee7fc2b2cc63f174c5 guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/bitcoin-cc8dff5f8ff8-x86_64-linux-gnu.tar.gz 319b52c1a62a9cdad2e3f1fac8dd22458be2a9c1e6a0d60b33cb27272d69e52a guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/SHA256SUMS.part 11300b916588cb060ac06e074b94bc5da852ab36446df903045ad593dce5056b guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-debug.zip 045fcb6ca721bdefb7490b3452f28449cb2b0449721dbbb20c174be76f96e1a3 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-setup-unsigned.exe 38c826537c8054a35103e5ab7ca4f97ca98551f23bcbadb0532f6ca3444e0731 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-unsigned.tar.gz 7c5f75c5a0b9b98540c8c779a6fc6f5e98d7de792d3a218e4ad7a68fa4027385 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64.zip ``` Guix Build (arm64): ```bash d54d16ae4d5ef2bb0d0dcebbd6d1ec4b0f0976063bf66222a320e68340f902d5 guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/SHA256SUMS.part 04c464043af256ee05d565040df9bb438151d4e041aa46f800fc567eba111c2f guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/bitcoin-cc8dff5f8ff8-arm-linux-gnueabihf-debug.tar.gz 097cd2f633bf6d3b8e922d81ce9f6dfe793589418e394abfa4e183861f5ad236 guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/bitcoin-cc8dff5f8ff8-arm-linux-gnueabihf.tar.gz 30c8074725b0701b1a781685f50a23ba038297b2633599f40792157daadc13cb guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/SHA256SUMS.part df6036e89c7e8746badcbcf805ec4f84070847833c562bc2185c15904b1b909a guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin-unsigned.dmg 8421c957b2b83c4afc3bc7f65f93798755acc99ac5921bd89b367c22c5b064d8 guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin-unsigned.tar.gz 076e8e185bc01dd43feb3fcbcec04eff5ca435b0fdf47c6f05008feec1cf11ac guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin.tar.gz 03de7ffcf8d98c61c3a5b763e9bcc6310c9895950f49768da2eeba4871d8478a guix-build-cc8dff5f8ff8/output/dist-archive/bitcoin-cc8dff5f8ff8.tar.gz 80ffe674a5fa86cfcf3f47eb8103dbfbc97dd74f793cf785c1347469f19b281f guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/SHA256SUMS.part 8ce2024c3fa65e6cd613ef526f90c5904675012b22eb39ccf94081d91e14340a guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64-linux-gnu-debug.tar.gz 89dc31c0306b0f1c79e13e5f705b73233695a802fd4946aac03364c45e7de984 guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64-linux-gnu.tar.gz 7ed1b82ba3d4c1a8ddc24c6f650aa6b2d1be08580b2ec32cfec0fd682828d797 guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/SHA256SUMS.part 01c7f706b236b342f4e0b5043c5788168806338cdaefd5541b04118665c7e40b guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64le-linux-gnu-debug.tar.gz 01767af5b190d0be4a075a5d038644b7dd0d1fc5f0b69698acaca92bfef960d0 guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64le-linux-gnu.tar.gz 414de662e0bb3df6a5c8fc1a3576c90a943998b802d97070e31bde434fc6a7f1 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/SHA256SUMS.part db55ddf8051e6dc80180f3eee12a7370bed1140959c34fb5de8d88f0344b23e2 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/bitcoin-cc8dff5f8ff8-riscv64-linux-gnu-debug.tar.gz bb19f15545d5a52e800ffb7f141915ab7083fb4fab9a80269f6714b28a294502 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/bitcoin-cc8dff5f8ff8-riscv64-linux-gnu.tar.gz d9241782d6e596ae02500ffe062501f80b064357bece5d10f7fd4d218240c3a1 guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/SHA256SUMS.part 1c3258a573e849a8efe6fce535a4f8737fb3a076ebe74ee29ca1e84a9113d24f guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin-unsigned.dmg 7e6d562dd636fcacae88bedca45b49a879901c0fc1309ea1812aba59bbbcb5d0 guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin-unsigned.tar.gz c4bc9c27466504417a4bd581cc024b8c5a370a51c8349c1f067752c98c2c14bc guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin.tar.gz 59aaf11181373efd2e281004ce968967a26fa95f90c5a25f44cc4c687e9ddb0a guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/SHA256SUMS.part fbcde4bfe21314104c7e6036e1f7f4b3ef0e41a7546fef5d1f2a6456b955778d guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/bitcoin-cc8dff5f8ff8-x86_64-linux-gnu-debug.tar.gz b1302146a0e96f7faa150d764aa0ca92b46e887a886532ee7fc2b2cc63f174c5 guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/bitcoin-cc8dff5f8ff8-x86_64-linux-gnu.tar.gz 319b52c1a62a9cdad2e3f1fac8dd22458be2a9c1e6a0d60b33cb27272d69e52a guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/SHA256SUMS.part 11300b916588cb060ac06e074b94bc5da852ab36446df903045ad593dce5056b guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-debug.zip 045fcb6ca721bdefb7490b3452f28449cb2b0449721dbbb20c174be76f96e1a3 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-setup-unsigned.exe 38c826537c8054a35103e5ab7ca4f97ca98551f23bcbadb0532f6ca3444e0731 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-unsigned.tar.gz 7c5f75c5a0b9b98540c8c779a6fc6f5e98d7de792d3a218e4ad7a68fa4027385 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64.zip ``` ACKs for top commit: gruve-p: ACK cc8dff5 hebasto: ACK cc8dff5 jarolrod: ACK cc8dff5 Tree-SHA512: d34a4c3e84efe9cade6de9d7ba5aafc0a5c6efce83e313552a248f2b1eb49dc032a50cf4f1c7eb4767e754a7b67f75a129be19e36a892776b16001c31f6725be

hebasto · 2022-09-21T10:40:41Z

Rebased 9077916 -> 75b51ed (pr25696.05 -> pr25696.06) on top of the merged #25873.

cc8dff5 depends: Boost 1.80.0 (fanquake) Pull request description: Mostly misc bug fixes and improvements, to the continually decreasing parts of Boost that we actually use. See: https://www.boost.org/users/history/version_1_80_0.html. Includes some boring upstreamed changes, i.e boostorg/multi_index#57, boostorg/signals2#60 that aid bitcoin#24742. Getting Boost modules to drop their usage of deprecated (redirect) headers means we can prune them from our depends tree. Also a requirement for bitcoin#25696. Guix Build (x86_64): ```bash e793a5ac9372b8fce6e19916be840eee99735bccdedf44b9bca006fd9ac8c395 guix-build-cc8dff5f8ff8/output/aarch64-linux-gnu/SHA256SUMS.part 001e0382f2b05e12f0ec5eaf09e001e31313ee3ab5367b0ba135ea2d7b863bf6 guix-build-cc8dff5f8ff8/output/aarch64-linux-gnu/bitcoin-cc8dff5f8ff8-aarch64-linux-gnu-debug.tar.gz a50229534b41eebd6c44001b56eb2be35b50d5f3a3b161a8fa46d7558b79693e guix-build-cc8dff5f8ff8/output/aarch64-linux-gnu/bitcoin-cc8dff5f8ff8-aarch64-linux-gnu.tar.gz d54d16ae4d5ef2bb0d0dcebbd6d1ec4b0f0976063bf66222a320e68340f902d5 guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/SHA256SUMS.part 04c464043af256ee05d565040df9bb438151d4e041aa46f800fc567eba111c2f guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/bitcoin-cc8dff5f8ff8-arm-linux-gnueabihf-debug.tar.gz 097cd2f633bf6d3b8e922d81ce9f6dfe793589418e394abfa4e183861f5ad236 guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/bitcoin-cc8dff5f8ff8-arm-linux-gnueabihf.tar.gz 30c8074725b0701b1a781685f50a23ba038297b2633599f40792157daadc13cb guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/SHA256SUMS.part df6036e89c7e8746badcbcf805ec4f84070847833c562bc2185c15904b1b909a guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin-unsigned.dmg 8421c957b2b83c4afc3bc7f65f93798755acc99ac5921bd89b367c22c5b064d8 guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin-unsigned.tar.gz 076e8e185bc01dd43feb3fcbcec04eff5ca435b0fdf47c6f05008feec1cf11ac guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin.tar.gz 03de7ffcf8d98c61c3a5b763e9bcc6310c9895950f49768da2eeba4871d8478a guix-build-cc8dff5f8ff8/output/dist-archive/bitcoin-cc8dff5f8ff8.tar.gz 80ffe674a5fa86cfcf3f47eb8103dbfbc97dd74f793cf785c1347469f19b281f guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/SHA256SUMS.part 8ce2024c3fa65e6cd613ef526f90c5904675012b22eb39ccf94081d91e14340a guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64-linux-gnu-debug.tar.gz 89dc31c0306b0f1c79e13e5f705b73233695a802fd4946aac03364c45e7de984 guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64-linux-gnu.tar.gz 7ed1b82ba3d4c1a8ddc24c6f650aa6b2d1be08580b2ec32cfec0fd682828d797 guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/SHA256SUMS.part 01c7f706b236b342f4e0b5043c5788168806338cdaefd5541b04118665c7e40b guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64le-linux-gnu-debug.tar.gz 01767af5b190d0be4a075a5d038644b7dd0d1fc5f0b69698acaca92bfef960d0 guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64le-linux-gnu.tar.gz 414de662e0bb3df6a5c8fc1a3576c90a943998b802d97070e31bde434fc6a7f1 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/SHA256SUMS.part db55ddf8051e6dc80180f3eee12a7370bed1140959c34fb5de8d88f0344b23e2 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/bitcoin-cc8dff5f8ff8-riscv64-linux-gnu-debug.tar.gz bb19f15545d5a52e800ffb7f141915ab7083fb4fab9a80269f6714b28a294502 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/bitcoin-cc8dff5f8ff8-riscv64-linux-gnu.tar.gz d9241782d6e596ae02500ffe062501f80b064357bece5d10f7fd4d218240c3a1 guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/SHA256SUMS.part 1c3258a573e849a8efe6fce535a4f8737fb3a076ebe74ee29ca1e84a9113d24f guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin-unsigned.dmg 7e6d562dd636fcacae88bedca45b49a879901c0fc1309ea1812aba59bbbcb5d0 guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin-unsigned.tar.gz c4bc9c27466504417a4bd581cc024b8c5a370a51c8349c1f067752c98c2c14bc guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin.tar.gz 59aaf11181373efd2e281004ce968967a26fa95f90c5a25f44cc4c687e9ddb0a guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/SHA256SUMS.part fbcde4bfe21314104c7e6036e1f7f4b3ef0e41a7546fef5d1f2a6456b955778d guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/bitcoin-cc8dff5f8ff8-x86_64-linux-gnu-debug.tar.gz b1302146a0e96f7faa150d764aa0ca92b46e887a886532ee7fc2b2cc63f174c5 guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/bitcoin-cc8dff5f8ff8-x86_64-linux-gnu.tar.gz 319b52c1a62a9cdad2e3f1fac8dd22458be2a9c1e6a0d60b33cb27272d69e52a guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/SHA256SUMS.part 11300b916588cb060ac06e074b94bc5da852ab36446df903045ad593dce5056b guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-debug.zip 045fcb6ca721bdefb7490b3452f28449cb2b0449721dbbb20c174be76f96e1a3 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-setup-unsigned.exe 38c826537c8054a35103e5ab7ca4f97ca98551f23bcbadb0532f6ca3444e0731 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-unsigned.tar.gz 7c5f75c5a0b9b98540c8c779a6fc6f5e98d7de792d3a218e4ad7a68fa4027385 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64.zip ``` Guix Build (arm64): ```bash d54d16ae4d5ef2bb0d0dcebbd6d1ec4b0f0976063bf66222a320e68340f902d5 guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/SHA256SUMS.part 04c464043af256ee05d565040df9bb438151d4e041aa46f800fc567eba111c2f guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/bitcoin-cc8dff5f8ff8-arm-linux-gnueabihf-debug.tar.gz 097cd2f633bf6d3b8e922d81ce9f6dfe793589418e394abfa4e183861f5ad236 guix-build-cc8dff5f8ff8/output/arm-linux-gnueabihf/bitcoin-cc8dff5f8ff8-arm-linux-gnueabihf.tar.gz 30c8074725b0701b1a781685f50a23ba038297b2633599f40792157daadc13cb guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/SHA256SUMS.part df6036e89c7e8746badcbcf805ec4f84070847833c562bc2185c15904b1b909a guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin-unsigned.dmg 8421c957b2b83c4afc3bc7f65f93798755acc99ac5921bd89b367c22c5b064d8 guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin-unsigned.tar.gz 076e8e185bc01dd43feb3fcbcec04eff5ca435b0fdf47c6f05008feec1cf11ac guix-build-cc8dff5f8ff8/output/arm64-apple-darwin/bitcoin-cc8dff5f8ff8-arm64-apple-darwin.tar.gz 03de7ffcf8d98c61c3a5b763e9bcc6310c9895950f49768da2eeba4871d8478a guix-build-cc8dff5f8ff8/output/dist-archive/bitcoin-cc8dff5f8ff8.tar.gz 80ffe674a5fa86cfcf3f47eb8103dbfbc97dd74f793cf785c1347469f19b281f guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/SHA256SUMS.part 8ce2024c3fa65e6cd613ef526f90c5904675012b22eb39ccf94081d91e14340a guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64-linux-gnu-debug.tar.gz 89dc31c0306b0f1c79e13e5f705b73233695a802fd4946aac03364c45e7de984 guix-build-cc8dff5f8ff8/output/powerpc64-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64-linux-gnu.tar.gz 7ed1b82ba3d4c1a8ddc24c6f650aa6b2d1be08580b2ec32cfec0fd682828d797 guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/SHA256SUMS.part 01c7f706b236b342f4e0b5043c5788168806338cdaefd5541b04118665c7e40b guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64le-linux-gnu-debug.tar.gz 01767af5b190d0be4a075a5d038644b7dd0d1fc5f0b69698acaca92bfef960d0 guix-build-cc8dff5f8ff8/output/powerpc64le-linux-gnu/bitcoin-cc8dff5f8ff8-powerpc64le-linux-gnu.tar.gz 414de662e0bb3df6a5c8fc1a3576c90a943998b802d97070e31bde434fc6a7f1 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/SHA256SUMS.part db55ddf8051e6dc80180f3eee12a7370bed1140959c34fb5de8d88f0344b23e2 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/bitcoin-cc8dff5f8ff8-riscv64-linux-gnu-debug.tar.gz bb19f15545d5a52e800ffb7f141915ab7083fb4fab9a80269f6714b28a294502 guix-build-cc8dff5f8ff8/output/riscv64-linux-gnu/bitcoin-cc8dff5f8ff8-riscv64-linux-gnu.tar.gz d9241782d6e596ae02500ffe062501f80b064357bece5d10f7fd4d218240c3a1 guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/SHA256SUMS.part 1c3258a573e849a8efe6fce535a4f8737fb3a076ebe74ee29ca1e84a9113d24f guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin-unsigned.dmg 7e6d562dd636fcacae88bedca45b49a879901c0fc1309ea1812aba59bbbcb5d0 guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin-unsigned.tar.gz c4bc9c27466504417a4bd581cc024b8c5a370a51c8349c1f067752c98c2c14bc guix-build-cc8dff5f8ff8/output/x86_64-apple-darwin/bitcoin-cc8dff5f8ff8-x86_64-apple-darwin.tar.gz 59aaf11181373efd2e281004ce968967a26fa95f90c5a25f44cc4c687e9ddb0a guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/SHA256SUMS.part fbcde4bfe21314104c7e6036e1f7f4b3ef0e41a7546fef5d1f2a6456b955778d guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/bitcoin-cc8dff5f8ff8-x86_64-linux-gnu-debug.tar.gz b1302146a0e96f7faa150d764aa0ca92b46e887a886532ee7fc2b2cc63f174c5 guix-build-cc8dff5f8ff8/output/x86_64-linux-gnu/bitcoin-cc8dff5f8ff8-x86_64-linux-gnu.tar.gz 319b52c1a62a9cdad2e3f1fac8dd22458be2a9c1e6a0d60b33cb27272d69e52a guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/SHA256SUMS.part 11300b916588cb060ac06e074b94bc5da852ab36446df903045ad593dce5056b guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-debug.zip 045fcb6ca721bdefb7490b3452f28449cb2b0449721dbbb20c174be76f96e1a3 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-setup-unsigned.exe 38c826537c8054a35103e5ab7ca4f97ca98551f23bcbadb0532f6ca3444e0731 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64-unsigned.tar.gz 7c5f75c5a0b9b98540c8c779a6fc6f5e98d7de792d3a218e4ad7a68fa4027385 guix-build-cc8dff5f8ff8/output/x86_64-w64-mingw32/bitcoin-cc8dff5f8ff8-win64.zip ``` ACKs for top commit: gruve-p: ACK bitcoin@cc8dff5 hebasto: ACK cc8dff5 jarolrod: ACK cc8dff5 Tree-SHA512: d34a4c3e84efe9cade6de9d7ba5aafc0a5c6efce83e313552a248f2b1eb49dc032a50cf4f1c7eb4767e754a7b67f75a129be19e36a892776b16001c31f6725be

Sjors · 2022-09-23T09:26:37Z

I may have a Windows dual boot system in a month or so, so I can test stuff like this.

jarolrod

ACK 75b51ed

I tested that external signer works again on windows. The external signer setting is now show in the GUI. I was able to connect an external signer, communicate with HWI, and create a new wallet. I confirmed the correct descriptors were passed, I was able to generate new addresses, receive testnet bitcoin, and sign & broadcast a transaction.

hebasto · 2022-10-28T13:55:06Z

Rebased 75b51ed -> 86cb0b7 (pr25696.06 -> pr25696.08) on top of the merged #26377.

Sjors · 2022-10-31T15:00:56Z

Tested 86cb0b7 using guix build. External signer works, but tests fail:

.\bitcoin-86cb0b7168a2\bin\test_bitcoin.exe
Running 534 test cases...
test/system_tests.cpp(61): error: in "system_tests/run_command": check e.code().value() == expected_error has failed [2 != 6]
test/system_tests.cpp(94): error: in "system_tests/run_command": check what.find(expected) != std::string::npos has failed

*** 2 failures are detected in the test module "Bitcoin Core Test Suite"

Tried both PowerShell and the regular Command Prompt.

hebasto · 2022-11-23T11:48:29Z

Updated 86cb0b7 -> 3e8160b (pr25696.08 -> pr25696.09):

rebased on top of the build: Update Boost to 1.81.0 in depends #26557 to avoid Boost source patching
fixed tests

@Sjors #25696 (comment) should be fixed now.

2427468 doc: Update Boost version in doc/dependencies.md (Hennadii Stepanov) e8b4201 build: Update Boost to 1.81.0 in depends (Hennadii Stepanov) Pull request description: Required for bitcoin/bitcoin#25696, also see bitcoin/bitcoin#25696 (comment). Guix build: ``` 0aade9c6a91d8550dea6cb07d4657c299a78d4434c1e78ef487e30e53239da64 guix-build-e8b4201ba2fd/output/aarch64-linux-gnu/SHA256SUMS.part f21964d25f96bca46ced3286b00e7e605d6517a6de7b00aa7ebf3bb6ee63d0d2 guix-build-e8b4201ba2fd/output/aarch64-linux-gnu/bitcoin-e8b4201ba2fd-aarch64-linux-gnu-debug.tar.gz 65e991407232714455a4bb5fb072b3b7f58f8f4696ca78b6756aae6e6497540b guix-build-e8b4201ba2fd/output/aarch64-linux-gnu/bitcoin-e8b4201ba2fd-aarch64-linux-gnu.tar.gz 92535c8b7ead8f3319858e55c7d076b3db174efd10b4b8dce8efbbd5e5b98819 guix-build-e8b4201ba2fd/output/arm-linux-gnueabihf/SHA256SUMS.part 9cd199415fbfe6ee6fdf5c57def2591327c97e7e31c4c7b323a738761fe6a285 guix-build-e8b4201ba2fd/output/arm-linux-gnueabihf/bitcoin-e8b4201ba2fd-arm-linux-gnueabihf-debug.tar.gz e13dacef38e68bb30283fda82bbf73864e5977b4cc6f82be41476246c7f51e90 guix-build-e8b4201ba2fd/output/arm-linux-gnueabihf/bitcoin-e8b4201ba2fd-arm-linux-gnueabihf.tar.gz e4c57c126927c2b40a3bd7c697e8b524140f989094c2a9ff216e1c03e90810da guix-build-e8b4201ba2fd/output/arm64-apple-darwin/SHA256SUMS.part 90b15bd6e8eab3c541a2a057402cf41630e5c72d07bf62b3d2d4d54698b3f03b guix-build-e8b4201ba2fd/output/arm64-apple-darwin/bitcoin-e8b4201ba2fd-arm64-apple-darwin-unsigned.dmg 848c7928d633f19912f340fa6df8b77756d291991dbd849b3d95761bcd445bad guix-build-e8b4201ba2fd/output/arm64-apple-darwin/bitcoin-e8b4201ba2fd-arm64-apple-darwin-unsigned.tar.gz 9880bfc57770372478c56b22b513d91d25a799591a345069e04c3f3a88bfc9ec guix-build-e8b4201ba2fd/output/arm64-apple-darwin/bitcoin-e8b4201ba2fd-arm64-apple-darwin.tar.gz e61cb6337dc1480292300fcd45e9b128c567222911cac3a9209955433e1f413b guix-build-e8b4201ba2fd/output/dist-archive/bitcoin-e8b4201ba2fd.tar.gz fd685ffcd1c5e32c25a84638fd47c5e14d0247dcf7d51e5317fea356f8c8347a guix-build-e8b4201ba2fd/output/powerpc64-linux-gnu/SHA256SUMS.part b710e9123684e459732553b1d6df2912257ac43b315db7f2e9288d95c76ce2b6 guix-build-e8b4201ba2fd/output/powerpc64-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64-linux-gnu-debug.tar.gz ea7878ea044dbfaf9c022de5bf7532bf00b028c8582d24ce67bec917f34869e9 guix-build-e8b4201ba2fd/output/powerpc64-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64-linux-gnu.tar.gz 737d9e054356ea50c7efe964a7b223eb81a7fcc10b235647ffcb588784e7e212 guix-build-e8b4201ba2fd/output/powerpc64le-linux-gnu/SHA256SUMS.part 46de2537ea90ddaced620a7dbfa1379b2d0cc80ae87d6225fef94a7196ff5166 guix-build-e8b4201ba2fd/output/powerpc64le-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64le-linux-gnu-debug.tar.gz 7e10be7f494bd4635477919ca9b9968b62054e0448f2963d1c25f0215361feae guix-build-e8b4201ba2fd/output/powerpc64le-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64le-linux-gnu.tar.gz cfb90022ea23526d8ca26259a06d2ec06a278e8fbcb05d6ba37fa3ef33ba1f77 guix-build-e8b4201ba2fd/output/riscv64-linux-gnu/SHA256SUMS.part ba45d57e19758682991fc51cc04c0e13e7e586b74ae1adae0273cd15bdd5cdb2 guix-build-e8b4201ba2fd/output/riscv64-linux-gnu/bitcoin-e8b4201ba2fd-riscv64-linux-gnu-debug.tar.gz 970941bee4c342b7b23065ce515d5e340b3aed989210a569faa33f638a3575f9 guix-build-e8b4201ba2fd/output/riscv64-linux-gnu/bitcoin-e8b4201ba2fd-riscv64-linux-gnu.tar.gz 3943c224a3fa0554ca75292f301ae02514c7ec100d9e13e185ed6ad4db932194 guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/SHA256SUMS.part 4c5f14af1961e33336423a2021b5da76b550ae1bc2284003d6009b1ced940eea guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/bitcoin-e8b4201ba2fd-x86_64-apple-darwin-unsigned.dmg 3ab7fd5623b414c4e0504c2943b84048524374150e9626b3a0b6931adc46109a guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/bitcoin-e8b4201ba2fd-x86_64-apple-darwin-unsigned.tar.gz 00c4c2da392eaee439984ab2bd614d2df6b48ba775350b2c6d48c3061e7667c5 guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/bitcoin-e8b4201ba2fd-x86_64-apple-darwin.tar.gz df20f8a3c8836ca5b7bac4c5104a31f4be76da75a67846d69cc8cbdf42339743 guix-build-e8b4201ba2fd/output/x86_64-linux-gnu/SHA256SUMS.part 68f72876397bfbf6cde73b8303bd081235407211d684cdb78fc932ffb0752942 guix-build-e8b4201ba2fd/output/x86_64-linux-gnu/bitcoin-e8b4201ba2fd-x86_64-linux-gnu-debug.tar.gz 769556d6a4a8baed5dfb81ab63afd1c0999101a5afeb2f7a1bab9b94ce6635bc guix-build-e8b4201ba2fd/output/x86_64-linux-gnu/bitcoin-e8b4201ba2fd-x86_64-linux-gnu.tar.gz 4b8487e9b16e0ec6645cb63ddd25149011797af14d596ed31a23130f201d8f57 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/SHA256SUMS.part 6fbad9caf9da6041f0d119be293d0895b50535604f86dda45a7b8345fb581a39 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64-debug.zip 42e84737cac5ec2d2052e5632f68bc6d211d5f02a171cb7347c067025edce13f guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64-setup-unsigned.exe 9205f92b1ecfcfa649552e27bb0942611dfac2a5f99c326b7de89bbeb46ad564 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64-unsigned.tar.gz 098d98161393e663da794cc336de8a4676fd2c8bc14dbc8b1cac1aaf6b4098f5 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64.zip ``` ACKs for top commit: fanquake: ACK 2427468 Tree-SHA512: 31d268e4608ab75f843c0cb1874d060cea762ebbd09b220a7f84054fb837f60b41b8452c181a4de7aa3f8aa27fd584d0a84e770209e02adfb978d2b5f625d7a6

… non-Windows

hebasto · 2023-01-06T10:57:41Z

Rebased bfd8f07 -> 1a0d8e1 (pr25696.10 -> pr25696.11) on top of the #26557.

Ready for (final?) reviewing :)

Sjors · 2023-01-06T15:34:16Z

Tests pass now.

tACK 1a0d8e1

Also checked that with 989451d Boost:Process is still detected correctly on Intel macOS.

2427468 doc: Update Boost version in doc/dependencies.md (Hennadii Stepanov) e8b4201 build: Update Boost to 1.81.0 in depends (Hennadii Stepanov) Pull request description: Required for bitcoin#25696, also see bitcoin#25696 (comment). Guix build: ``` 0aade9c6a91d8550dea6cb07d4657c299a78d4434c1e78ef487e30e53239da64 guix-build-e8b4201ba2fd/output/aarch64-linux-gnu/SHA256SUMS.part f21964d25f96bca46ced3286b00e7e605d6517a6de7b00aa7ebf3bb6ee63d0d2 guix-build-e8b4201ba2fd/output/aarch64-linux-gnu/bitcoin-e8b4201ba2fd-aarch64-linux-gnu-debug.tar.gz 65e991407232714455a4bb5fb072b3b7f58f8f4696ca78b6756aae6e6497540b guix-build-e8b4201ba2fd/output/aarch64-linux-gnu/bitcoin-e8b4201ba2fd-aarch64-linux-gnu.tar.gz 92535c8b7ead8f3319858e55c7d076b3db174efd10b4b8dce8efbbd5e5b98819 guix-build-e8b4201ba2fd/output/arm-linux-gnueabihf/SHA256SUMS.part 9cd199415fbfe6ee6fdf5c57def2591327c97e7e31c4c7b323a738761fe6a285 guix-build-e8b4201ba2fd/output/arm-linux-gnueabihf/bitcoin-e8b4201ba2fd-arm-linux-gnueabihf-debug.tar.gz e13dacef38e68bb30283fda82bbf73864e5977b4cc6f82be41476246c7f51e90 guix-build-e8b4201ba2fd/output/arm-linux-gnueabihf/bitcoin-e8b4201ba2fd-arm-linux-gnueabihf.tar.gz e4c57c126927c2b40a3bd7c697e8b524140f989094c2a9ff216e1c03e90810da guix-build-e8b4201ba2fd/output/arm64-apple-darwin/SHA256SUMS.part 90b15bd6e8eab3c541a2a057402cf41630e5c72d07bf62b3d2d4d54698b3f03b guix-build-e8b4201ba2fd/output/arm64-apple-darwin/bitcoin-e8b4201ba2fd-arm64-apple-darwin-unsigned.dmg 848c7928d633f19912f340fa6df8b77756d291991dbd849b3d95761bcd445bad guix-build-e8b4201ba2fd/output/arm64-apple-darwin/bitcoin-e8b4201ba2fd-arm64-apple-darwin-unsigned.tar.gz 9880bfc57770372478c56b22b513d91d25a799591a345069e04c3f3a88bfc9ec guix-build-e8b4201ba2fd/output/arm64-apple-darwin/bitcoin-e8b4201ba2fd-arm64-apple-darwin.tar.gz e61cb6337dc1480292300fcd45e9b128c567222911cac3a9209955433e1f413b guix-build-e8b4201ba2fd/output/dist-archive/bitcoin-e8b4201ba2fd.tar.gz fd685ffcd1c5e32c25a84638fd47c5e14d0247dcf7d51e5317fea356f8c8347a guix-build-e8b4201ba2fd/output/powerpc64-linux-gnu/SHA256SUMS.part b710e9123684e459732553b1d6df2912257ac43b315db7f2e9288d95c76ce2b6 guix-build-e8b4201ba2fd/output/powerpc64-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64-linux-gnu-debug.tar.gz ea7878ea044dbfaf9c022de5bf7532bf00b028c8582d24ce67bec917f34869e9 guix-build-e8b4201ba2fd/output/powerpc64-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64-linux-gnu.tar.gz 737d9e054356ea50c7efe964a7b223eb81a7fcc10b235647ffcb588784e7e212 guix-build-e8b4201ba2fd/output/powerpc64le-linux-gnu/SHA256SUMS.part 46de2537ea90ddaced620a7dbfa1379b2d0cc80ae87d6225fef94a7196ff5166 guix-build-e8b4201ba2fd/output/powerpc64le-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64le-linux-gnu-debug.tar.gz 7e10be7f494bd4635477919ca9b9968b62054e0448f2963d1c25f0215361feae guix-build-e8b4201ba2fd/output/powerpc64le-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64le-linux-gnu.tar.gz cfb90022ea23526d8ca26259a06d2ec06a278e8fbcb05d6ba37fa3ef33ba1f77 guix-build-e8b4201ba2fd/output/riscv64-linux-gnu/SHA256SUMS.part ba45d57e19758682991fc51cc04c0e13e7e586b74ae1adae0273cd15bdd5cdb2 guix-build-e8b4201ba2fd/output/riscv64-linux-gnu/bitcoin-e8b4201ba2fd-riscv64-linux-gnu-debug.tar.gz 970941bee4c342b7b23065ce515d5e340b3aed989210a569faa33f638a3575f9 guix-build-e8b4201ba2fd/output/riscv64-linux-gnu/bitcoin-e8b4201ba2fd-riscv64-linux-gnu.tar.gz 3943c224a3fa0554ca75292f301ae02514c7ec100d9e13e185ed6ad4db932194 guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/SHA256SUMS.part 4c5f14af1961e33336423a2021b5da76b550ae1bc2284003d6009b1ced940eea guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/bitcoin-e8b4201ba2fd-x86_64-apple-darwin-unsigned.dmg 3ab7fd5623b414c4e0504c2943b84048524374150e9626b3a0b6931adc46109a guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/bitcoin-e8b4201ba2fd-x86_64-apple-darwin-unsigned.tar.gz 00c4c2da392eaee439984ab2bd614d2df6b48ba775350b2c6d48c3061e7667c5 guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/bitcoin-e8b4201ba2fd-x86_64-apple-darwin.tar.gz df20f8a3c8836ca5b7bac4c5104a31f4be76da75a67846d69cc8cbdf42339743 guix-build-e8b4201ba2fd/output/x86_64-linux-gnu/SHA256SUMS.part 68f72876397bfbf6cde73b8303bd081235407211d684cdb78fc932ffb0752942 guix-build-e8b4201ba2fd/output/x86_64-linux-gnu/bitcoin-e8b4201ba2fd-x86_64-linux-gnu-debug.tar.gz 769556d6a4a8baed5dfb81ab63afd1c0999101a5afeb2f7a1bab9b94ce6635bc guix-build-e8b4201ba2fd/output/x86_64-linux-gnu/bitcoin-e8b4201ba2fd-x86_64-linux-gnu.tar.gz 4b8487e9b16e0ec6645cb63ddd25149011797af14d596ed31a23130f201d8f57 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/SHA256SUMS.part 6fbad9caf9da6041f0d119be293d0895b50535604f86dda45a7b8345fb581a39 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64-debug.zip 42e84737cac5ec2d2052e5632f68bc6d211d5f02a171cb7347c067025edce13f guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64-setup-unsigned.exe 9205f92b1ecfcfa649552e27bb0942611dfac2a5f99c326b7de89bbeb46ad564 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64-unsigned.tar.gz 098d98161393e663da794cc336de8a4676fd2c8bc14dbc8b1cac1aaf6b4098f5 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64.zip ``` ACKs for top commit: fanquake: ACK 2427468 Tree-SHA512: 31d268e4608ab75f843c0cb1874d060cea762ebbd09b220a7f84054fb837f60b41b8452c181a4de7aa3f8aa27fd584d0a84e770209e02adfb978d2b5f625d7a6

hebasto · 2023-01-25T16:08:55Z

@achow101 @luke-jr @jarolrod

Mind looking into this PR?

achow101 · 2023-03-09T02:00:06Z

ACK 1a0d8e1

fanquake · 2023-03-09T07:47:09Z

post-merge Concept NACK. I don't know why we are leaning back into this.

hebasto · 2023-03-09T09:53:54Z

I don't know why we are leaning back into this.

Because using external signers is one of the best security options for users who run their Bitcoin Core software on Windows.

post-merge Concept NACK.

Better alternatives are welcome.

2427468 doc: Update Boost version in doc/dependencies.md (Hennadii Stepanov) e8b4201 build: Update Boost to 1.81.0 in depends (Hennadii Stepanov) Pull request description: Required for bitcoin#25696, also see bitcoin#25696 (comment). Guix build: ``` 0aade9c6a91d8550dea6cb07d4657c299a78d4434c1e78ef487e30e53239da64 guix-build-e8b4201ba2fd/output/aarch64-linux-gnu/SHA256SUMS.part f21964d25f96bca46ced3286b00e7e605d6517a6de7b00aa7ebf3bb6ee63d0d2 guix-build-e8b4201ba2fd/output/aarch64-linux-gnu/bitcoin-e8b4201ba2fd-aarch64-linux-gnu-debug.tar.gz 65e991407232714455a4bb5fb072b3b7f58f8f4696ca78b6756aae6e6497540b guix-build-e8b4201ba2fd/output/aarch64-linux-gnu/bitcoin-e8b4201ba2fd-aarch64-linux-gnu.tar.gz 92535c8b7ead8f3319858e55c7d076b3db174efd10b4b8dce8efbbd5e5b98819 guix-build-e8b4201ba2fd/output/arm-linux-gnueabihf/SHA256SUMS.part 9cd199415fbfe6ee6fdf5c57def2591327c97e7e31c4c7b323a738761fe6a285 guix-build-e8b4201ba2fd/output/arm-linux-gnueabihf/bitcoin-e8b4201ba2fd-arm-linux-gnueabihf-debug.tar.gz e13dacef38e68bb30283fda82bbf73864e5977b4cc6f82be41476246c7f51e90 guix-build-e8b4201ba2fd/output/arm-linux-gnueabihf/bitcoin-e8b4201ba2fd-arm-linux-gnueabihf.tar.gz e4c57c126927c2b40a3bd7c697e8b524140f989094c2a9ff216e1c03e90810da guix-build-e8b4201ba2fd/output/arm64-apple-darwin/SHA256SUMS.part 90b15bd6e8eab3c541a2a057402cf41630e5c72d07bf62b3d2d4d54698b3f03b guix-build-e8b4201ba2fd/output/arm64-apple-darwin/bitcoin-e8b4201ba2fd-arm64-apple-darwin-unsigned.dmg 848c7928d633f19912f340fa6df8b77756d291991dbd849b3d95761bcd445bad guix-build-e8b4201ba2fd/output/arm64-apple-darwin/bitcoin-e8b4201ba2fd-arm64-apple-darwin-unsigned.tar.gz 9880bfc57770372478c56b22b513d91d25a799591a345069e04c3f3a88bfc9ec guix-build-e8b4201ba2fd/output/arm64-apple-darwin/bitcoin-e8b4201ba2fd-arm64-apple-darwin.tar.gz e61cb6337dc1480292300fcd45e9b128c567222911cac3a9209955433e1f413b guix-build-e8b4201ba2fd/output/dist-archive/bitcoin-e8b4201ba2fd.tar.gz fd685ffcd1c5e32c25a84638fd47c5e14d0247dcf7d51e5317fea356f8c8347a guix-build-e8b4201ba2fd/output/powerpc64-linux-gnu/SHA256SUMS.part b710e9123684e459732553b1d6df2912257ac43b315db7f2e9288d95c76ce2b6 guix-build-e8b4201ba2fd/output/powerpc64-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64-linux-gnu-debug.tar.gz ea7878ea044dbfaf9c022de5bf7532bf00b028c8582d24ce67bec917f34869e9 guix-build-e8b4201ba2fd/output/powerpc64-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64-linux-gnu.tar.gz 737d9e054356ea50c7efe964a7b223eb81a7fcc10b235647ffcb588784e7e212 guix-build-e8b4201ba2fd/output/powerpc64le-linux-gnu/SHA256SUMS.part 46de2537ea90ddaced620a7dbfa1379b2d0cc80ae87d6225fef94a7196ff5166 guix-build-e8b4201ba2fd/output/powerpc64le-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64le-linux-gnu-debug.tar.gz 7e10be7f494bd4635477919ca9b9968b62054e0448f2963d1c25f0215361feae guix-build-e8b4201ba2fd/output/powerpc64le-linux-gnu/bitcoin-e8b4201ba2fd-powerpc64le-linux-gnu.tar.gz cfb90022ea23526d8ca26259a06d2ec06a278e8fbcb05d6ba37fa3ef33ba1f77 guix-build-e8b4201ba2fd/output/riscv64-linux-gnu/SHA256SUMS.part ba45d57e19758682991fc51cc04c0e13e7e586b74ae1adae0273cd15bdd5cdb2 guix-build-e8b4201ba2fd/output/riscv64-linux-gnu/bitcoin-e8b4201ba2fd-riscv64-linux-gnu-debug.tar.gz 970941bee4c342b7b23065ce515d5e340b3aed989210a569faa33f638a3575f9 guix-build-e8b4201ba2fd/output/riscv64-linux-gnu/bitcoin-e8b4201ba2fd-riscv64-linux-gnu.tar.gz 3943c224a3fa0554ca75292f301ae02514c7ec100d9e13e185ed6ad4db932194 guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/SHA256SUMS.part 4c5f14af1961e33336423a2021b5da76b550ae1bc2284003d6009b1ced940eea guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/bitcoin-e8b4201ba2fd-x86_64-apple-darwin-unsigned.dmg 3ab7fd5623b414c4e0504c2943b84048524374150e9626b3a0b6931adc46109a guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/bitcoin-e8b4201ba2fd-x86_64-apple-darwin-unsigned.tar.gz 00c4c2da392eaee439984ab2bd614d2df6b48ba775350b2c6d48c3061e7667c5 guix-build-e8b4201ba2fd/output/x86_64-apple-darwin/bitcoin-e8b4201ba2fd-x86_64-apple-darwin.tar.gz df20f8a3c8836ca5b7bac4c5104a31f4be76da75a67846d69cc8cbdf42339743 guix-build-e8b4201ba2fd/output/x86_64-linux-gnu/SHA256SUMS.part 68f72876397bfbf6cde73b8303bd081235407211d684cdb78fc932ffb0752942 guix-build-e8b4201ba2fd/output/x86_64-linux-gnu/bitcoin-e8b4201ba2fd-x86_64-linux-gnu-debug.tar.gz 769556d6a4a8baed5dfb81ab63afd1c0999101a5afeb2f7a1bab9b94ce6635bc guix-build-e8b4201ba2fd/output/x86_64-linux-gnu/bitcoin-e8b4201ba2fd-x86_64-linux-gnu.tar.gz 4b8487e9b16e0ec6645cb63ddd25149011797af14d596ed31a23130f201d8f57 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/SHA256SUMS.part 6fbad9caf9da6041f0d119be293d0895b50535604f86dda45a7b8345fb581a39 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64-debug.zip 42e84737cac5ec2d2052e5632f68bc6d211d5f02a171cb7347c067025edce13f guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64-setup-unsigned.exe 9205f92b1ecfcfa649552e27bb0942611dfac2a5f99c326b7de89bbeb46ad564 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64-unsigned.tar.gz 098d98161393e663da794cc336de8a4676fd2c8bc14dbc8b1cac1aaf6b4098f5 guix-build-e8b4201ba2fd/output/x86_64-w64-mingw32/bitcoin-e8b4201ba2fd-win64.zip ``` ACKs for top commit: fanquake: ACK 2427468 Tree-SHA512: 31d268e4608ab75f843c0cb1874d060cea762ebbd09b220a7f84054fb837f60b41b8452c181a4de7aa3f8aa27fd584d0a84e770209e02adfb978d2b5f625d7a6

fanquake mentioned this pull request Jul 25, 2022

Re-enable external signer support for Windows #25111

Closed

DrahtBot added the Build system label Jul 25, 2022

luke-jr suggested changes Jul 25, 2022

View reviewed changes

configure.ac Outdated Show resolved Hide resolved

hebasto force-pushed the 220725-boost branch from 94bbce8 to 6f21aa8 Compare July 25, 2022 21:51

DrahtBot mentioned this pull request Jul 26, 2022

build: Improve depends build system robustness #22552

Closed

hebasto force-pushed the 220725-boost branch from 6f21aa8 to b08deec Compare July 26, 2022 10:57

fanquake requested a review from Sjors July 27, 2022 14:10

hebasto mentioned this pull request Jul 27, 2022

test: Drop unused boost workaround #25723

Merged

hebasto force-pushed the 220725-boost branch from b08deec to 0444353 Compare July 28, 2022 10:39

fanquake reviewed Aug 1, 2022

View reviewed changes

depends/patches/boost/mingw32_process.patch Outdated Show resolved Hide resolved

DrahtBot mentioned this pull request Aug 14, 2022

build: prune Boost headers in depends #24742

Closed

fanquake mentioned this pull request Aug 19, 2022

depends: Boost 1.80.0 #25873

Merged

hebasto force-pushed the 220725-boost branch from 0444353 to 9077916 Compare August 19, 2022 10:42

hebasto marked this pull request as ready for review August 19, 2022 10:43

hebasto force-pushed the 220725-boost branch from 9077916 to 75b51ed Compare September 21, 2022 10:23

jarolrod approved these changes Oct 14, 2022

View reviewed changes

hebasto force-pushed the 220725-boost branch from 8db9f3c to 86cb0b7 Compare October 28, 2022 13:29

hebasto marked this pull request as ready for review October 28, 2022 13:47

DrahtBot mentioned this pull request Nov 12, 2022

build: Add CMake-based build system #25797

Closed

16 tasks

hebasto mentioned this pull request Nov 23, 2022

build: Update Boost to 1.81.0 in depends #26557

Merged

hebasto force-pushed the 220725-boost branch from 86cb0b7 to 3e8160b Compare November 23, 2022 11:44

hebasto marked this pull request as draft November 23, 2022 11:45

hebasto force-pushed the 220725-boost branch from 3e8160b to bfd8f07 Compare November 23, 2022 14:30

luke-jr and others added 2 commits January 6, 2023 10:51

configure: Detect compatibility of Boost.Process rather than hardcode…

989451d

… non-Windows

build: Re-enable external signer on Windows

1a0d8e1

hebasto force-pushed the 220725-boost branch from bfd8f07 to 1a0d8e1 Compare January 6, 2023 10:54

hebasto marked this pull request as ready for review January 6, 2023 10:55

DrahtBot requested a review from jarolrod March 9, 2023 02:00

achow101 merged commit 23e2bfc into bitcoin:master Mar 9, 2023

hebasto deleted the 220725-boost branch March 9, 2023 10:01

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 9, 2023

Merge bitcoin#25696: build: Re-enable external signer on Windows

05882ab

Sjors mentioned this pull request Feb 27, 2024

build: disable external-signer for Windows #28967

Merged

bitcoin locked and limited conversation to collaborators Mar 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Re-enable external signer on Windows #25696

build: Re-enable external signer on Windows #25696

hebasto commented Jul 25, 2022 •

edited

Loading

DrahtBot commented Jul 25, 2022 •

edited

Loading

fanquake commented Jul 27, 2022

hebasto commented Jul 27, 2022

hebasto commented Jul 28, 2022

Sjors commented Aug 5, 2022

fanquake commented Aug 19, 2022

hebasto commented Aug 19, 2022

jarolrod commented Sep 14, 2022 •

edited

Loading

hebasto commented Sep 21, 2022

Sjors commented Sep 23, 2022

jarolrod left a comment

hebasto commented Oct 28, 2022

Sjors commented Oct 31, 2022 •

edited

Loading

hebasto commented Nov 23, 2022

hebasto commented Jan 6, 2023

Sjors commented Jan 6, 2023

hebasto commented Jan 25, 2023

achow101 commented Mar 9, 2023

fanquake commented Mar 9, 2023

hebasto commented Mar 9, 2023

build: Re-enable external signer on Windows #25696

build: Re-enable external signer on Windows #25696

Conversation

hebasto commented Jul 25, 2022 • edited Loading

DrahtBot commented Jul 25, 2022 • edited Loading

Reviews

Conflicts

fanquake commented Jul 27, 2022

hebasto commented Jul 27, 2022

hebasto commented Jul 28, 2022

Sjors commented Aug 5, 2022

fanquake commented Aug 19, 2022

hebasto commented Aug 19, 2022

jarolrod commented Sep 14, 2022 • edited Loading

hebasto commented Sep 21, 2022

Sjors commented Sep 23, 2022

jarolrod left a comment

Choose a reason for hiding this comment

hebasto commented Oct 28, 2022

Sjors commented Oct 31, 2022 • edited Loading

hebasto commented Nov 23, 2022

hebasto commented Jan 6, 2023

Sjors commented Jan 6, 2023

hebasto commented Jan 25, 2023

achow101 commented Mar 9, 2023

fanquake commented Mar 9, 2023

hebasto commented Mar 9, 2023

hebasto commented Jul 25, 2022 •

edited

Loading

DrahtBot commented Jul 25, 2022 •

edited

Loading

jarolrod commented Sep 14, 2022 •

edited

Loading

Sjors commented Oct 31, 2022 •

edited

Loading