refactor: Remove unused CDataStream::rdbuf method

[maflcko]

It is unused and seems unlikely to be ever used.

[theStack]

Code-review ACK fabbbe3

Seems like this method was introduced by Satoshi and hasn't been used for >10 years (last use was removed with commit 5ce4c2a) has never been used 👀

[aureleoules]

ACK fabbbe3

[stickies-v]

Compact() also seems unused, can remove that too?

[maflcko]

Seems like this method was introduced by Satoshi and hasn't been used for >10 years (last use was removed with commit 5ce4c2a) eyes

Was this ever used? Looks like the commit you link to was a call to ip::tcp::iostream::rdbuf(), which may not be CDataStream, but rather https://www.boost.org/doc/libs/1_80_0/doc/html/boost_asio/reference/basic_socket_iostream/rdbuf.html

[maflcko]

Compact() also seems unused, can remove that too?

As opposed to rdbuf one could imagine a use case for this, so I kept it for now. But happy to drop as well if reviewers want that.

[theStack]

Seems like this method was introduced by Satoshi and hasn't been used for >10 years (last use was removed with commit 5ce4c2a) eyes

Was this ever used? Looks like the commit you link to was a call to ip::tcp::iostream::rdbuf(), which may not be CDataStream, but rather https://www.boost.org/doc/libs/1_80_0/doc/html/boost_asio/reference/basic_socket_iostream/rdbuf.html

Oh you're right, it seems the method you removed was indeed never used then 🤔