[qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) #7334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // as well as the children. Children should never be partially selected in the first place. | ||
| // Should be fixed in Qt5.4 and above. https://bugreports.qt.io/browse/QTBUG-43473 | ||
| // TODO: Remove this temporary qt5 fix after Qt5.3 and Qt5.4 are no longer used. | ||
| // Fixed in Qt5.5 and above: https://bugreports.qt.io/browse/QTBUG-43473 |
There was a problem hiding this comment.
IMO we should keep the explanation of the workaround. But right, Qt5.4 does not fix the issue, it needs Qt 5.5+ for that.
There was a problem hiding this comment.
The linked bug report explains this pretty well. No need to copy that into our source, I guess?
|
We're never proactive with removing compatibility workarounds, so I don't think this will make much difference in practice. |
laanwj
added a commit
that referenced
this pull request
Jan 14, 2016
fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 5, 2017
fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)
UdjinM6
pushed a commit
to dashpay/dash
that referenced
this pull request
Sep 7, 2017
* Merge pull request bitcoin#7154 a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli) * Merge pull request bitcoin#7218 fa5769e [qt] Fix misleading translation (MarcoFalke) fa8c8d7 torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke) * Merge pull request bitcoin#7255 6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake) 5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake) * Merge pull request bitcoin#7263 a5a0831 Double semicolon cleanup. (21E14) * Merge pull request bitcoin#7334 fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke) * Merge pull request bitcoin#7329 9d263bd Typo fixes in comments (Chris Wheeler) * Merge bitcoin#7396: [Qt] Add option to increase/decrease font size in the console window 43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli) 56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli) 3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli) * Merge bitcoin#7628: QT: Add 'copy full transaction details' option b51ed40 QT: Add 'copy full transaction details' option (Eric Shaw) * Merge bitcoin#7668: Fix history deletion bug after font size change 21e45a0 Fix history deletion bug after font change (Andrew C) * Copy/Move font size related icons into theme folders * Use formatTxDate for date/time in TxPlainTextRole
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's not remove it too early. I'd still prefer something like
#if QT_VERSION >= 0x050000 && QT_VERSION <= 0x050500