New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) #7334

Merged
merged 1 commit into from Jan 14, 2016

Conversation

Projects
None yet
3 participants
@MarcoFalke
Member

MarcoFalke commented Jan 13, 2016

Let's not remove it too early. I'd still prefer something like

#if QT_VERSION >= 0x050000 && QT_VERSION <= 0x050500

@jonasschnelli jonasschnelli added the GUI label Jan 13, 2016

// as well as the children. Children should never be partially selected in the first place.
// Should be fixed in Qt5.4 and above. https://bugreports.qt.io/browse/QTBUG-43473
// TODO: Remove this temporary qt5 fix after Qt5.3 and Qt5.4 are no longer used.
// Fixed in Qt5.5 and above: https://bugreports.qt.io/browse/QTBUG-43473

This comment has been minimized.

@jonasschnelli

jonasschnelli Jan 14, 2016

Member

IMO we should keep the explanation of the workaround. But right, Qt5.4 does not fix the issue, it needs Qt 5.5+ for that.

@jonasschnelli

jonasschnelli Jan 14, 2016

Member

IMO we should keep the explanation of the workaround. But right, Qt5.4 does not fix the issue, it needs Qt 5.5+ for that.

This comment has been minimized.

@MarcoFalke

MarcoFalke Jan 14, 2016

Member

The linked bug report explains this pretty well. No need to copy that into our source, I guess?

@MarcoFalke

MarcoFalke Jan 14, 2016

Member

The linked bug report explains this pretty well. No need to copy that into our source, I guess?

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jan 14, 2016

Member

We're never proactive with removing compatibility workarounds, so I don't think this will make much difference in practice.
But ACK for the sake of correctness.

Member

laanwj commented Jan 14, 2016

We're never proactive with removing compatibility workarounds, so I don't think this will make much difference in practice.
But ACK for the sake of correctness.

@laanwj laanwj merged commit fa989fb into bitcoin:master Jan 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 14, 2016

Merge pull request #7334
fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1601-qt55Workaround branch Jan 14, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 5, 2017

Merge pull request #7334
fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)

UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 7, 2017

Backport Bitcoin Qt/Gui changes up to 0.14.x part 1 (#1614)
* Merge pull request #7154

a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli)

* Merge pull request #7218

fa5769e [qt] Fix misleading translation (MarcoFalke)
fa8c8d7 torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke)

* Merge pull request #7255

6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake)
5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)

* Merge pull request #7263

a5a0831 Double semicolon cleanup. (21E14)

* Merge pull request #7334

fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)

* Merge pull request #7329

9d263bd Typo fixes in comments (Chris Wheeler)

* Merge #7396: [Qt] Add option to increase/decrease font size in the console window

43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli)
56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli)
3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli)

* Merge #7628: QT: Add 'copy full transaction details' option

b51ed40 QT: Add 'copy full transaction details' option (Eric Shaw)

* Merge #7668: Fix history deletion bug after font size change

21e45a0 Fix history deletion bug after font change (Andrew C)

* Copy/Move font size related icons into theme folders

* Use formatTxDate for date/time in TxPlainTextRole
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment