crypto-browserify dependency

[STRML]

A call to require('crypto') inside browserify or webpack will automatically use the crypto-browserify package in the browser environment, and node crypto in Node.

Is there a reason to include this library? It causes large package bloat in Node projects.

[dcousens]

We were unable to release without including it because the main browserify package was not using latest, or would resolve to an incompatible version of it.

[dcousens]

It could be removed now.

[STRML]

Thanks!
On 2/2/15 4:54 PM, Wei Lu wrote:

Closed #345 #345
via #346 #346.

—
Reply to this email directly or view it on GitHub
#345 (comment).

[dthorpe]

Just to clarify: a bitcoinjs-lib app built with browserify will still include crypto-browserify files, but just the ones provided by browserify itself? This fix was to remove use of an additional crypto-browserify by bitcoinjs-lib that is no longer needed because browserify's built-ins are improved.

I'm still seeing a minimal bitcoinjs-lib app built with browserify that references crypto producing an output js of about 650k. Is this the expected size (without js minification)?

Thanks

[dcousens]

@dthorpe this issue was based on the fact we previously had an inline dependency for crypto-browserify in the package.json, not the fact that the library can be browserified in general.
The reason for that was because we relied on the latest version of crypto-browserify.

A smaller (~303k) minimal bitcoinjs-lib build should now be possible with 1.5.6 (see #376 for 1.5.x release notes)