Skip to content

Conversation

@dcousens
Copy link
Contributor

@dcousens dcousens commented Jun 4, 2014

This pull request changes the underlying types used by convert to use Buffer instead of byte arrays.
This pulls it into line with the rest of the code base, and removes some pointless conversions.

It also removes convert.reverseEndian, and adds more tests (and respective edge cases) to the convert tests.
Lastly, it fixes 2 incorrect (undefined) test descriptions in Address and HDNode.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) when pulling 943621f on dcousens:convclean into 63e6cf9 on bitcoinjs:master.

weilu added a commit that referenced this pull request Jun 4, 2014
Convert Buffers, not Byte Arrays
@weilu weilu merged commit 7f51832 into bitcoinjs:master Jun 4, 2014
@dcousens dcousens deleted the convclean branch June 4, 2014 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants