JSHint and fixes #205
Merged
JSHint and fixes #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No logic change, just using the variables that are defined instead of repeating code.
It is advised to use ?w=0 in comparing this commit.
Contributor
Author
|
The abundant changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a jshint
run-scripttarget to ourpackage.jsonand a customjshint.jsonconfiguration that is currently configured based on my interpretation of what is being enforced throughout the repository.It is not currently running over
tests/*.js, but I'm open to adding it if we decide that is desired.Added in are also some low hanging fruit that have appeared since this was last run in #82.