Skip to content

Wallet test fixes #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2014
Merged

Wallet test fixes #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69dfd32
Wallet: add missing variable wallet
dcousens Sep 8, 2014
c3f8869
tests: Wallet test was not comprehensive
dcousens Sep 8, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/wallet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ describe('Wallet', function() {
describe('setUnspentOutputs', function() {
var utxo
var expectedOutputKey
var wallet

beforeEach(function() {
utxo = {
Expand Down Expand Up @@ -632,9 +633,11 @@ describe('Wallet', function() {
})

it('skips change if it is not above dust threshold', function() {
var fee = 14570
var tx = wallet.createTx(to, value)
assert.equal(tx.outs.length, 1)
var tx1 = wallet.createTx(to, value - 546)
Copy link

@glorat glorat Sep 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is just a clean-up and unrelated to the kill sinon specific change?
Edit: Just read your commit comment where you mentioned it :) Cool

assert.equal(tx1.outs.length, 1)

var tx2 = wallet.createTx(to, value - 547)
assert.equal(tx2.outs.length, 2)
})
})
})
Expand Down