Deprecate Buffer interop in preparation for 2.0.0 #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@weilu I also question that technically this is |
Contributor
|
@dcousens I think that'd be a good idea, given that we already have |
Contributor
|
Merging this as the |
weilu
added a commit
that referenced
this pull request
Sep 22, 2014
Deprecate Buffer interop in preparation for 2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.0.0, a major focus is on making the API as simple as possible, and to avoid possible interop concerns.
This is just one of those preparations.
The BIP32 specification does mention:
Implying maybe, that you could expose the pure byte format in a standard way, however I feel the checksum is useful in most contexts, and unless a use case can be garnered for
toBuffer, I'm happy to remove them in2.0.0.