pre-2.0.0, deprecations #317

dcousens · 2014-11-26T01:58:44Z

Most of this has been previously vetted, but this is the [almost] all inclusive 2.0.0 PR.

@weilu did we want to split it up into smaller PR's for simpler review over the next few days?

dcousens · 2014-11-26T02:00:07Z

I could probably squash the ECPair commits given the API has not existed previously to this.

dcousens · 2014-11-26T03:03:56Z

Squashed into 0f86931 and 8b1d135, addition then replacement of ECKey/ECPubKey commits.

weilu · 2014-11-27T14:30:10Z

A single PR is fine. What's up with Travis CI?

dcousens · 2014-11-27T23:43:36Z

@weilu sinon seems to be broken in 0.11

dcousens · 2014-11-27T23:59:51Z

Rebased on HEAD, squashed Transaction test and ECPair integration test fixes.

dcousens · 2014-11-28T00:20:53Z

@weilu reference sinonjs/sinon#613

~~Added a commit to ignore node 0.11 until sinon is fixed upstream~~

dcousens · 2014-11-28T00:29:01Z

Rebased on HEAD

dcousens · 2014-11-28T00:44:43Z

Fixed block.js tests to use RawTransaction in 967d570.
Added consistent import/export hashType checking and corresponding tests into ECSignature

coveralls · 2014-11-28T03:09:36Z

Coverage increased (+0.83%) when pulling 2746027 on 2.0.0 into 110cb86 on master.

dcousens · 2014-11-29T01:43:14Z

Will add a commit to ignore node 0.11 if sinon isn't fixed before we want to merge merge this.

dcousens · 2014-12-01T00:23:39Z

Rebased on #323

coveralls · 2014-12-01T00:27:37Z

Coverage increased (+0.98%) when pulling 25c2c42 on 2.0.0 into b1cb56c on master.

weilu · 2014-12-07T04:37:30Z

var bitcoin = require("bitcoinjs-lib")

Backward incompatible changes:

removed

bitcoin.crypto.HmacSHA256 // use require('crypto').createHmac instead
bitcoin.crypto.HmacSHA512 // use require('crypto').createHmac instead
bitcoin.base58check // use require("bs58check") instead
bitcoin.Wallet // build your own
bitcoin.HDNode.fromBuffer // use `bitcoin.HDNode.fromBase58 instead
bitcoin.HDNode.fromHex // use `bitcoin.HDNode.fromBase58 instead
bitcoin.HDNode.toBuffer // use `bitcoin.HDNode.toBase58 instead
bitcoin.HDNode.toHex // use `bitcoin.HDNode.toBase58 instead
bitcoin.Transaction.prototype.sign // use bitcoin.TransactionBuilder.prototype.sign instead
bitcoin.Transaction.prototype.signInput // use bitcoin.TransactionBuilder.prototype.sign instead
bitcoin.Transaction.prototype.validateInput // ?? roll your own?
bitcoin.ECKey // use bitcoin.ECPair instead
bitcoin.ECPubKey // use bitcoin.ECPair instead

updated

bitcoin.Message -> bitcoin.message
bitcoin.Transaction -> bitcoin.RawTransaction
bitcoin.TransactionBuilder -> bitcoin.Transaction
bitcoin.HDNode.toBase58(isPrivate) -> bitcoin.HDNode.prototype.neutered().toBase58() for exporting a public key and bitcoin.HDNode.prototype.toBase58() for exporting a private key
bitcoin.scripts.dataOutput -> bitcoin.nullDataOutput
Transaction.prototype.hashForSignature(prevOutScript, inIndex, hashType) -> Transaction.prototype.hashForSignature(inIndex, prevOutScript, hashType)
Transaction.prototype.addInput(hash, ...): hash could be a string, Transaction or Buffer -> hash can only be a Buffer. For TransactionBuilder.prototype.addInput(prevTx, ...), prevTx can still be a string, Transaction or Buffer.
Transaction.prototype.addOutput(scriptPubKey, ...): scriptPubKey could be a string, Address or Buffer -> scriptPubKey can only be a Buffer. For TransactionBuilder.prototype.addOutput(scriptPubKey, ...), scriptPubKey can be a string, Address or Buffer.

Writing up the change notes makes me think that the bitcoin.Transaction -> bitcoin.RawTransaction, bitcoin.TransactionBuilder -> bitcoin.Transaction change should come in a separate major bump. It can be really confusing for people otherwise. @dcousens thoughts?

dcousens · 2014-12-08T00:34:58Z

bitcoin.Transaction.prototype.validateInput
This is as simple as using hashForSignature and ECPair.prototype.validate. What could be added is the hashType to use the existing hashType modifier if it already exists at that vout.

How does a separate major version bump help?

dcousens · 2015-02-05T22:52:43Z

Rebased on #329

Use bs58check package solely from here on.

dcousens · 2015-03-02T06:52:40Z

I've rebased on master.

This should be good to merge quite quickly, as it is almost all just removals, with the addition of bufferutils.equal and the movement of parameter type coercion to TransactionBuilder specifically.

I also removed ECPair, as will put it in another PR for review.

dcousens · 2015-03-02T06:55:58Z

Will merge before end of tonight, post-merge review is welcome if you miss the merge, but most of this has already been reviewed several times, so it should just be a final check over.

coveralls · 2015-03-02T07:06:53Z

Coverage increased (+1.04%) to 98.82% when pulling 77f81cf on 2.0.0 into 0bba215 on master.

weilu · 2015-03-02T07:07:46Z

I'll review this again today.

On Mon, Mar 2, 2015 at 3:52 PM, Daniel Cousens notifications@github.com
wrote:

I've rebased on master.

This should be good to merge quite quickly, as it is almost all just
removals, with the addition of bufferutils.equal and the movement of
parameter type coercion to TransactionBuilder specifically.

Removed ECPair (will put it in another PR for review).

—
Reply to this email directly or view it on GitHub
#317 (comment)
.

dcousens · 2015-03-02T07:10:08Z

Sounds good. Will freeze as of now.

edit: Was just fixing a test accidentally broken in the commit before 4668cb1. Good to go now.

coveralls · 2015-03-02T07:16:39Z

Coverage increased (+1.04%) to 98.82% when pulling 4668cb1 on 2.0.0 into 0bba215 on master.

dcousens · 2015-03-02T07:17:47Z

Change log as of this PR.

Backward incompatible changes:

removed

bitcoin.crypto.HmacSHA256 // use require('crypto').createHmac instead
bitcoin.crypto.HmacSHA512 // use require('crypto').createHmac instead
bitcoin.base58check // use require("bs58check") instead
bitcoin.Wallet // build your own
bitcoin.HDNode.fromBuffer // use `bitcoin.HDNode.fromBase58 instead
bitcoin.HDNode.fromHex // use `bitcoin.HDNode.fromBase58 instead
bitcoin.HDNode.toBuffer // use `bitcoin.HDNode.toBase58 instead
bitcoin.HDNode.toHex // use `bitcoin.HDNode.toBase58 instead
bitcoin.Transaction.prototype.sign // use bitcoin.TransactionBuilder.prototype.sign instead
bitcoin.Transaction.prototype.signInput // use bitcoin.TransactionBuilder.prototype.sign instead
bitcoin.Transaction.prototype.validateInput // use hashForSignature and ecdsa verify

updated

bitcoin.Message -> bitcoin.message
bitcoin.HDNode.toBase58(isPrivate) -> bitcoin.HDNode.prototype.neutered().toBase58() for exporting a extended public key and bitcoin.HDNode.prototype.toBase58() for exporting an extended private key
bitcoin.scripts.dataOutput -> bitcoin.nullDataOutput
Transaction.prototype.hashForSignature(prevOutScript, inIndex, hashType) -> Transaction.prototype.hashForSignature(inIndex, prevOutScript, hashType)
Transaction.prototype.addInput(hash, ...): hash could be a string, Transaction or Buffer -> hash can now only be a Buffer.
Transaction.prototype.addOutput(scriptPubKey, ...): scriptPubKey could be a string, Address or Buffer -> scriptPubKey can now only be a Buffer.
TransactionBuilder API unchanged.

weilu · 2015-03-02T17:24:15Z

LGTM

TransactionBuilder API unchanged.

If it's not changed, it should not be under updated section

pre-2.0.0, deprecations

dcousens · 2015-03-02T21:15:08Z

It was an amendment to what you had, which specified changes, even though
it was unchanged.
On 3 Mar 2015 4:24 am, "Wei Lu" notifications@github.com wrote:

LGTM

TransactionBuilder API unchanged.

If it's not changed, it should not be under updated section

—
Reply to this email directly or view it on GitHub
#317 (comment)
.

dcousens added this to the 2.0.0 milestone Nov 26, 2014

dcousens force-pushed the 2.0.0 branch from fc98498 to cbb9b8e Compare November 26, 2014 03:03

dcousens force-pushed the 2.0.0 branch 2 times, most recently from c2132e6 to 5e62b61 Compare November 27, 2014 23:58

dcousens force-pushed the 2.0.0 branch from 762f721 to 225d0f0 Compare November 28, 2014 00:28

dcousens force-pushed the 2.0.0 branch from 757bb98 to 0231f1a Compare November 28, 2014 00:43

dcousens force-pushed the 2.0.0 branch 2 times, most recently from f1e8442 to 2746027 Compare November 28, 2014 03:05

dcousens force-pushed the 2.0.0 branch 2 times, most recently from 093e8f8 to c536926 Compare November 29, 2014 01:37

dcousens force-pushed the 2.0.0 branch from c536926 to 25c2c42 Compare December 1, 2014 00:23

dcousens force-pushed the 2.0.0 branch 2 times, most recently from b9dc89b to 5db6e34 Compare December 12, 2014 06:08

dcousens force-pushed the 2.0.0 branch from 5db6e34 to 48ad0c1 Compare February 5, 2015 22:45

dcousens force-pushed the 2.0.0 branch from 48ad0c1 to eddb9c4 Compare February 23, 2015 00:30

dcousens force-pushed the 2.0.0 branch from eddb9c4 to 4bca4b0 Compare February 23, 2015 00:43

dcousens added 3 commits March 2, 2015 14:02

remove base58check

5f84846

Use bs58check package solely from here on.

rename Message to message

bdb372d

crypto: remove Hmac* exposure in API

08cc8f8

dcousens force-pushed the 2.0.0 branch from 4bca4b0 to 7141df9 Compare March 2, 2015 06:25

dcousens added 2 commits March 2, 2015 17:27

remove deprecated functionality

8d3686d

bufferutils: add equal

5beee20

dcousens force-pushed the 2.0.0 branch from 7141df9 to 7f3b4c9 Compare March 2, 2015 06:51

TxBuilder: move param coercion from Transaction to TxBuilder

7f3b4c9

dcousens changed the title ~~2.0.0~~ pre-2.0.0, deprecations Mar 2, 2015

dcousens self-assigned this Mar 2, 2015

dcousens force-pushed the 2.0.0 branch 2 times, most recently from 2d0ca4e to cb3c291 Compare March 2, 2015 07:06

dcousens force-pushed the 2.0.0 branch from cb3c291 to 4668cb1 Compare March 2, 2015 07:09

TxBuilder: simplify addInput

4668cb1

weilu added a commit that referenced this pull request Mar 2, 2015

Merge pull request #317 from bitcoinjs/2.0.0

b132714

pre-2.0.0, deprecations

weilu merged commit b132714 into master Mar 2, 2015

dcousens mentioned this pull request Mar 2, 2015

Patches for 1.x.y #371

Closed

dcousens deleted the 2.0.0 branch April 28, 2015 06:41

dcousens added the breaking change label Apr 28, 2015

dcousens mentioned this pull request Aug 13, 2015

Add CHANGELOG #435

Closed

pre-2.0.0, deprecations #317

pre-2.0.0, deprecations #317

Uh oh!

Conversation

dcousens commented Nov 26, 2014

Uh oh!

dcousens commented Nov 26, 2014

Uh oh!

dcousens commented Nov 26, 2014

Uh oh!

weilu commented Nov 27, 2014

Uh oh!

dcousens commented Nov 27, 2014

Uh oh!

dcousens commented Nov 27, 2014

Uh oh!

dcousens commented Nov 28, 2014

Uh oh!

dcousens commented Nov 28, 2014

Uh oh!

dcousens commented Nov 28, 2014

Uh oh!

coveralls commented Nov 28, 2014

Uh oh!

dcousens commented Nov 29, 2014

Uh oh!

dcousens commented Dec 1, 2014

Uh oh!

coveralls commented Dec 1, 2014

Uh oh!

weilu commented Dec 7, 2014

Uh oh!

dcousens commented Dec 8, 2014

Uh oh!

dcousens commented Feb 5, 2015

Uh oh!

dcousens commented Mar 2, 2015

Uh oh!

dcousens commented Mar 2, 2015

Uh oh!

coveralls commented Mar 2, 2015

Uh oh!

weilu commented Mar 2, 2015

Uh oh!

dcousens commented Mar 2, 2015

Uh oh!

coveralls commented Mar 2, 2015

Uh oh!

dcousens commented Mar 2, 2015

Uh oh!

weilu commented Mar 2, 2015

Uh oh!

dcousens commented Mar 2, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants