Skip to content

Conversation

@dcousens
Copy link
Contributor

This should fix the related integration test occasionally failing due to a timeout.
Currently 900+ transactions are returned unnecessarily.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.25% when pulling 234ae84 on testfix into 64678e7 on master.

dcousens added a commit that referenced this pull request Jan 28, 2015
integration: avoid excessive blockchain requests
@dcousens dcousens merged commit b93903e into master Jan 28, 2015
@dcousens dcousens deleted the testfix branch January 28, 2015 05:49
@dcousens
Copy link
Contributor Author

@weilu post ACK if necessary

@weilu
Copy link
Contributor

weilu commented Jan 28, 2015

nice.

@dcousens
Copy link
Contributor Author

Technically this is less malleability resistant, but I don't think that is
a major concern compared for this test case.
On 28 Jan 2015 8:25 pm, "Wei Lu" notifications@github.com wrote:

nice.


Reply to this email directly or view it on GitHub
#343 (comment)
.

@weilu
Copy link
Contributor

weilu commented Jan 28, 2015

Malleability isn't what the tests here care about, so I think it's totally fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants