Allow constructing HDNode from an ECPubKey. #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is already covered in |
dcousens
added a commit
that referenced
this pull request
Feb 24, 2015
Allow constructing HDNode from an ECPubKey.
Contributor
|
Will be adding tests and an assertion that the public key is compressed, post-merge. |
dcousens
added a commit
that referenced
this pull request
Feb 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can only construct an HD node using either a private key or an ECPoint. When using an ECPoint it is turned into an ECPubKey. This pull request makes it possible to use an ECPubKey directly.