ECPair #385
Merged
ECPair #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
force-pushed
the
ecpair
branch
2 times, most recently
from
6c8bd34 to
4c8b0f3
Compare
Contributor
Author
There was a problem hiding this comment.
These are the same private keys, just different compression flags (they were wrong previously)
Member
|
As far as I can tell, to summarize this PR, this pretty much renames |
Contributor
Author
|
It merges |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request (finally) integrates
ECPairacross the project and pulls it into master.Aside from the discussions we've had where this is proposed as a much better, more coherent API for users, thanks to 3183229, the total test time is also almost 40% shorter.