Modulo tests #460
Merged
Modulo tests #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
Removed this test, as sinonjs/sinon#613 doesn't look like it'll be fixed any time soon.
We already check that the parameters themselves are being used, it would just have been an added precaution to verify the call behaviour.
4 tasks
dcousens
added a commit
that referenced
this pull request
Oct 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a [failing] test for checking the RNG output for
ECPair.makeRandom, see #447 (comment)The test is failing only because, prior to this PR,
makeRandomwas accepting of a RNG value of0.The
ECPairconstructor threw in this case, (Private key must be >0), so it is not an issue, but may be unexpected.Given the astronomically small possibility of this case, it is almost certainly an error, so I'm not even sure if looping is the right action.
However, to be consistent, I've fixed it for now.
Thoughts @weilu ?