Skip to content

Conversation

harding
Copy link
Collaborator

@harding harding commented May 24, 2020

Note: if there's any further significant discussion on the <65 byte transaction thread, I'll updated that news item. I probably should've waited until next week to write about it, but there wasn't any other significant news this week that I saw.

Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just one comment.

Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack Exchange section looks good @bitschmidty. One small suggestion inline.

sub-project.

- [Bitcoin Core #18594][] allows the `bitcoin-cli` command to print the
balances of each wallet loaded in multiwallet mode using the
Copy link
Collaborator

@jonatack jonatack May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps: s/balances/balance/ since each wallet has one balance.

Note that this is the first time that a RPC/CLI command can return multiple wallet balances.

It was initially proposed as a server-side RPC implementation in bitcoin/bitcoin#18453 (cf https://bitcoincore.reviews/18453), but discussion is ongoing on the interface to adopt for a general multiwallet API -- see also issue bitcoin/bitcoin#18715 and PR proposal bitcoin/bitcoin#18734.

Copy link
Member

@adamjonas adamjonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Thanks @harding!

is that the PSBT form of the transaction is returned by the
`txprepare` RPC, but the PR is tagged in GitHub as working towards
dual funding of new channels (see [Newsletter #83][news83 interactive]
about using PSBT for interactive construction of funding transactions).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
about using PSBT for interactive construction of funding transactions).
using PSBT for interactive construction of funding transactions).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping this suggestion so that I can make a different change in the doc, but thanks!

@harding
Copy link
Collaborator Author

harding commented May 26, 2020

ACK StackExchange section and LND4227 description, thanks @bitschmidty and @dongcarl!

@jnewbery
Copy link
Contributor

ACK. All looks good to me. Thanks @harding @bitschmidty @dongcarl!

@bitschmidty bitschmidty force-pushed the 2020-05-27-newsletter branch from c5a7e2a to 1fed856 Compare May 27, 2020 10:57
@bitschmidty bitschmidty merged commit 4c93ec9 into bitcoinops:master May 27, 2020
@bitschmidty
Copy link
Contributor

Removed RC fixme check, squashed, merged!

Thanks @harding @dongcarl for authoring and the "J team" for reviewing @jnewbery @jonatack @adamjonas

@harding
Copy link
Collaborator Author

harding commented May 27, 2020

Removed RC fixme check

Whoops, sorry. Thanks @bitschmidty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants