-
Notifications
You must be signed in to change notification settings - Fork 143
Newsletters: add 99 (2020-05-27) #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stack Exchange section looks good @bitschmidty. One small suggestion inline.
sub-project. | ||
|
||
- [Bitcoin Core #18594][] allows the `bitcoin-cli` command to print the | ||
balances of each wallet loaded in multiwallet mode using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps: s/balances/balance/ since each wallet has one balance.
Note that this is the first time that a RPC/CLI command can return multiple wallet balances.
It was initially proposed as a server-side RPC implementation in bitcoin/bitcoin#18453 (cf https://bitcoincore.reviews/18453), but discussion is ongoing on the interface to adopt for a general multiwallet API -- see also issue bitcoin/bitcoin#18715 and PR proposal bitcoin/bitcoin#18734.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Thanks @harding!
is that the PSBT form of the transaction is returned by the | ||
`txprepare` RPC, but the PR is tagged in GitHub as working towards | ||
dual funding of new channels (see [Newsletter #83][news83 interactive] | ||
about using PSBT for interactive construction of funding transactions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about using PSBT for interactive construction of funding transactions). | |
using PSBT for interactive construction of funding transactions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping this suggestion so that I can make a different change in the doc, but thanks!
ACK StackExchange section and LND4227 description, thanks @bitschmidty and @dongcarl! |
ACK. All looks good to me. Thanks @harding @bitschmidty @dongcarl! |
c5a7e2a
to
1fed856
Compare
Removed RC fixme check, squashed, merged! Thanks @harding @dongcarl for authoring and the "J team" for reviewing @jnewbery @jonatack @adamjonas |
Whoops, sorry. Thanks @bitschmidty! |
LND #4227
@dongcarlNote: if there's any further significant discussion on the
<65
byte transaction thread, I'll updated that news item. I probably should've waited until next week to write about it, but there wasn't any other significant news this week that I saw.