Add fundrawtransaction #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! With this we can support tools like atomic swaps decred/atomicswap#37 |
|
Can 86ce0cc be removed? This doesn't actually seem to be included (and doesn't look like it's needed in xt since we don't manipulate the min relay fee): |
Some code stolen from Jonas Schnelli <jonas.schnelli@include7.ch>
….py RPC test - added missing mempool sync between block generations
Since unspendable outputs can't be spent, there is no threshold at which it would be uneconomic to spend them. This primarily targets transaction outputs with `OP_RETURN`. --- Initially based on: commit 9cf0ae26350033d43d5dd3c95054c0d1b1641eda Author: zathras-crypto <zathrasc@gmail.com> Date: Wed Mar 25 02:04:02 2015 -0700 Changes: - cherry-picked on top of bitcoin:master - added RPC test for fundrawtransaction
This indicates that, eg, we have a public key for a key which may be used as a pay-to-pubkey-hash. It generally means that we can create a valid scriptSig except for missing private key(s) with which to create signatures.
Some code and test cases stolen from Bryan Bishop <bryan@ledgerx.com> (pull #5524).
Note from cherry-picker: Skipped changes in mempool_limit
Includes following commits from Bitcoin Core: 777799 - [qa] Fix pyton syntax in rpc tests fab389 - [qa] rpc-test: Normalize assert() fa524d - [qa] Use python2/3 syntax fa2cea - [qa] rpc-tests: Properly use integers, floats faa41e - [qa] py2: Unfiddle strings into bytes explicitly
Strict flag forces type check on all object keys.
Includes following commits from Bitcoin Core: fa389d - [qa] Switch to py3 fac934 - [qa] Remove hardcoded "4 nodes" from test_framework
- Mark methods as override, as not to shadow parent. - Remove default nHashType value, so not to risk hashtype being interpreted as amount. - Use SIGHASH_FORKID
|
Ok, the file was collapsed when I happened to search for that code. |
dgenr8
approved these changes
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fundrawtransaction RPC call. Includes the following from Bitcoin Core:
bitcoin/bitcoin#6088 - fundrawtransaction
bitcoin/bitcoin#6417 - [QA] fix possible reorg issue in (fund)rawtransaction(s).py RPC test
bitcoin/bitcoin#6444 - Exempt unspendable transaction outputs from dust checks
bitcoin/bitcoin#6415 - Implement watchonly support in fundrawtransaction
bitcoin/bitcoin#6828 - [rpc-tests] fundrawtransaction: Update fee after minRelayTxFee increase
commit bebe58 from bitcoin/bitcoin#7296
bitcoin/bitcoin#7506 - Use CCoinControl selection in CWallet::FundTransaction
bitcoin/bitcoin#7518 - Add multiple options to fundrawtransaction
bitcoin/bitcoin#7967 - [RPC] add feerate option to fundrawtransaction
Includes the updates up until their test framework supported python3. There are more changes that should be ported over after this.