Implement watchonly support in fundrawtransaction #6415

Merged
merged 10 commits into from Aug 14, 2015

Conversation

Projects
None yet
5 participants
@TheBlueMatt
Contributor

TheBlueMatt commented Jul 10, 2015

No description provided.

@TheBlueMatt

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Jul 10, 2015

Contributor

Realized I forgot to submit this after #6088....

Contributor

TheBlueMatt commented Jul 10, 2015

Realized I forgot to submit this after #6088....

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jul 14, 2015

Member

Needs rebase

Member

jonasschnelli commented Jul 14, 2015

Needs rebase

@laanwj laanwj added the Feature label Jul 17, 2015

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Jul 23, 2015

Contributor

ut ACK

Contributor

jgarzik commented Jul 23, 2015

ut ACK

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Aug 8, 2015

Nit: the distinction here is really whether we know the script to sign with. Mind calling it ISMINE_WATCH_DESTINATION (as in: we're overriding our decision about whether we know how to sign for a particular destination) or ISMINE_WATCH_KEY (as in: we're overriding our decision about whether we know how to sign for a particular key).

Nit: the distinction here is really whether we know the script to sign with. Mind calling it ISMINE_WATCH_DESTINATION (as in: we're overriding our decision about whether we know how to sign for a particular destination) or ISMINE_WATCH_KEY (as in: we're overriding our decision about whether we know how to sign for a particular key).

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Aug 8, 2015

Owner

Maybe ISMINE_WATCH_(UN)SIGNABLE to make it really explicit what we're talking about?

Owner

TheBlueMatt replied Aug 8, 2015

Maybe ISMINE_WATCH_(UN)SIGNABLE to make it really explicit what we're talking about?

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Aug 8, 2015

Every watch-only result is unsignable... or we wouldn't need to watch it :)

How about ISMINE_WATCH_UNKNOWN_SCRIPT?

sipa replied Aug 8, 2015

Every watch-only result is unsignable... or we wouldn't need to watch it :)

How about ISMINE_WATCH_UNKNOWN_SCRIPT?

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Aug 8, 2015

Owner

Oops, meant ISMINE_WATCH_(UN)SOLVEABLE

Owner

TheBlueMatt replied Aug 8, 2015

Oops, meant ISMINE_WATCH_(UN)SOLVEABLE

This comment has been minimized.

Show comment
Hide comment

sipa replied Aug 8, 2015

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Aug 8, 2015

Owner

Done.

Owner

TheBlueMatt replied Aug 8, 2015

Done.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Aug 10, 2015

I guess in theory you could import and p2pkh address as p2sh, by importing the p2pkh script as redeemscript. But that's probably pointless and confusing.

I guess in theory you could import and p2pkh address as p2sh, by importing the p2pkh script as redeemscript. But that's probably pointless and confusing.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Aug 10, 2015

Member

Untested ACK.

Member

sipa commented Aug 10, 2015

Untested ACK.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Aug 10, 2015

Member
Member

sipa commented Aug 10, 2015

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Aug 10, 2015

Member
Member

sipa commented Aug 10, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 14, 2015

Member

utACK

Member

laanwj commented Aug 14, 2015

utACK

@laanwj laanwj merged commit d042854 into bitcoin:master Aug 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 14, 2015

Merge pull request #6415
d042854 SQUASH "Implement watchonly support in fundrawtransaction" (Matt Corallo)
428a898 SQUASH "Add have-pubkey distinction to ISMINE flags" (Matt Corallo)
6bdb474 Implement watchonly support in fundrawtransaction (Matt Corallo)
f5813bd Add logic to track pubkeys as watch-only, not just scripts (Matt Corallo)
d3354c5 Add have-pubkey distinction to ISMINE flags (Matt Corallo)
5c17059 Update importaddress help to push its use to script-only (Matt Corallo)
a1d7df3 Add importpubkey method to import a watch-only pubkey (Matt Corallo)
907a425 Add p2sh option to importaddress to import redeemScripts (Matt Corallo)
983d2d9 Split up importaddress into helper functions (Matt Corallo)
cfc3dd3 Also remove pay-2-pubkey from watch when adding a priv key (Matt Corallo)

@daira daira referenced this pull request in zcash/zcash Mar 4, 2017

Merged

Bitcoin 0.12 RPC PRs 1 #2100

@str4d str4d referenced this pull request in zcash/zcash Mar 29, 2017

Open

Bitcoin 0.12 wallet PRs 1 #2225

@dagurval dagurval referenced this pull request in bitcoinxt/bitcoinxt Dec 27, 2017

Merged

Add fundrawtransaction #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment