Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usddeck.c #1004

Merged
merged 1 commit into from
May 3, 2022
Merged

Update usddeck.c #1004

merged 1 commit into from
May 3, 2022

Conversation

roeeSch
Copy link
Contributor

@roeeSch roeeSch commented Mar 23, 2022

Support config.txt files with lines which are pure comments such as the first line here:

# Config Vesion 1.2.3
100   # frequency
3    # buffer size
...
gyro.x
gyro.y
gyro.z
acc.x

Support config.txt files with lines which are pure comments such as:
# Config Vesion 1.2.3
@knmcguire
Copy link
Contributor

knmcguire commented Mar 23, 2022

Ah great, thanks!

This will fix issue #915? I wanted to look at this for a triage meeting but perhaps not necessary anymore!

We are in the middle or a release so we might wait a bit with merging this, but in the mean time @tobbeanton could take a look at it!

@knmcguire knmcguire requested a review from tobbeanton March 23, 2022 14:18
@roeeSch
Copy link
Contributor Author

roeeSch commented Mar 23, 2022

@knmcguire, I think this will fix #915.
I verified this functionality by updating the firmware and adding a comment to config.txt and checking the logs on the SD.

@krichardsson krichardsson merged commit 2fe503d into bitcraze:master May 3, 2022
@krichardsson
Copy link
Contributor

Merged
Thanks!

@krichardsson
Copy link
Contributor

Fixes #915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants