Removed waiting for system start in memory subsystem #1028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one or more of the self-tests fails (red LED blinking rapidly) there's an issue when connecting to the Crazyflie where we will not get callbacks for connected or connection failed, it will just hangs.
The reason for this hanging is due to the following:
systemWaitStart()
systemStart()
will not be made and the memory subsystem task will not be unlockedconnected
orconnection_failed
is calledThe solution in this PR is not great since it possibly creates a race condition when registering memories. Registration cannot be done after the task has started, but it's not certain that all the modules and/or deck drivers have registered what they need by then. So if the registration is late and assert will be triggered.