-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Virtual Com Port (composite USB) and DSHOT motor signal protocol #1050
Conversation
Passthrough based on Betaflight work but bit timing had to be adjusted STM32 USB device driver updated
Adapted brushless code after KBuild was merged.
I'm getting a build error for the cfbl.
Results in this error:
The CI doesn't use this config yet so that is why it didn't catch this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a lot... and I won't be able to review it all, for the communication part @evoggy is probably the best.
Maybe we need to do release testing width for the size of this PR
@@ -0,0 +1,5 @@ | |||
CONFIG_MOTORS_ESC_PROTOCOL_DSHOT=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the configfile is called cfbl_defconfig eventhough the platform calls it cf21b. Should we try to uniform it somehow?
src/drivers/interface/motors.h
Outdated
@@ -95,6 +95,26 @@ | |||
#define MOTORS_BL_PWM_PERIOD MOTORS_BL_PWM_CNT_FOR_PERIOD | |||
#define MOTORS_BL_PWM_PRESCALE (uint16_t)(MOTORS_BL_PWM_PRESCALE_RAW - 1) | |||
#define MOTORS_BL_POLARITY TIM_OCPolarity_Low | |||
#elif defined(CONFIG_MOTORS_ESC_PROTOCOL_DSHOT) | |||
/** | |||
* *VARNING* Make sure the brushless driver is configured correctly as on the Crazyflie with normal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: Warning
This is a pretty hefty PR but it was hard to break it down...
Documentation is still lacking and will be made when things are a bit more clear and figured out as part of getting Bolt out of early access.
The crazyflie-lib-python cfusb driver needs to be new for the cfclient to be able to connect using USB.